-
Notifications
You must be signed in to change notification settings - Fork 667
Scheduler: Appointment Form - fix paddings #32865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sjbur
wants to merge
37
commits into
DevExpress:26_1
Choose a base branch
from
sjbur:issue-3609_26_1
base: 26_1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−24
Open
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
6a7fb5d
css: fix paddings
sjbur 7cbc547
css: fix icon height and padding
sjbur 81d046f
css: small refactor
sjbur a878728
feat: update screenshots
sjbur abcfc78
test: add test for static label mode
sjbur 819e011
feat: update screenshots
sjbur c327505
fix: try not to create icons if they not needed
sjbur 899a57a
Merge branch '26_1' into issue-3609_26_1
sjbur fd28978
feat: update screenshots
sjbur 6a7e7f4
feat: update screenshots
sjbur 8d39503
feat: try to hide icons using visible and colSpan
sjbur 0bc2283
feat: update masks
sjbur 37f2254
feat: update masks
sjbur fad4c02
fix: revert changes in jquery.html
sjbur e175347
refactor: undo naming
sjbur fb1e061
fix: revert changes in jquery.html
sjbur ca225a8
feat: update masks
sjbur be7b7eb
feat: update masks
sjbur 0b3d93e
Merge branch '26_1' into issue-3609_26_1
sjbur 85c6b28
feat: update masks
sjbur 6fb0d16
css: update styles
sjbur 2b689ff
css: update styles
sjbur 3202178
feat: try to remove screenshot
sjbur c605cd8
Merge branch '26_1' into issue-3609_26_1
sjbur 6cc7304
feat: update screenshot
sjbur 73e220b
feat: add changes to showicon logic
sjbur 3d63876
feat: update screenshot
sjbur 9e6d517
feat: add test for main form without icons
sjbur 31cf255
feat: add test for main form without icons
sjbur ee87797
feat: update screenshot
sjbur ae311e4
Merge branch '26_1' into issue-3609_26_1
sjbur df2e604
refactor: small refactor
sjbur f9ca89b
feat: update show icon logic
sjbur 4160fdb
feat: undo recurrence form
sjbur ee90aed
Merge branch '26_1' into issue-3609_26_1
sjbur 9bb7a06
refactor: undo code style changes
sjbur 655f1c4
refactor: small refactoring
sjbur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Binary file added
BIN
+31.8 KB
...lons/scheduler__appointment__main-form__icons-mode-none (fluent.blue.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+32.3 KB
...ns/scheduler__appointment__main-form__with-labelMode-static (generic.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+35.6 KB
...eduler__appointment__main-form__with-labelMode-static (material.blue.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-27 Bytes
(100%)
.../etalons/scheduler__appointment__recurrence-form__daily (fluent.blue.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...ons/scheduler__appointment__recurrence-form__daily (fluent.blue.light)_mask.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-30 Bytes
(100%)
...etalons/scheduler__appointment__recurrence-form__hourly (fluent.blue.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+5 Bytes
(100%)
...ns/scheduler__appointment__recurrence-form__hourly (fluent.blue.light)_mask.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-50 Bytes
(100%)
...etalons/scheduler__appointment__recurrence-form__mobile (fluent.blue.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-239 Bytes
(57%)
...ns/scheduler__appointment__recurrence-form__mobile (fluent.blue.light)_mask.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-18 Bytes
(100%)
...talons/scheduler__appointment__recurrence-form__monthly (fluent.blue.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6 Bytes
(100%)
...alons/scheduler__appointment__recurrence-form__readonly (fluent.blue.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-53 Bytes
(100%)
...etalons/scheduler__appointment__recurrence-form__weekly (fluent.blue.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-42 Bytes
(100%)
...ons/scheduler__appointment__recurrence-form__with-icons (fluent.blue.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...cheduler__appointment__recurrence-form__with-icons (fluent.blue.light)_mask.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-123 Bytes
(100%)
...er__appointment__recurrence-form__with-labelMode-static (fluent.blue.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-30 Bytes
(100%)
...etalons/scheduler__appointment__recurrence-form__yearly (fluent.blue.light).png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+3 Bytes
(100%)
...ns/scheduler__appointment__recurrence-form__yearly (fluent.blue.light)_mask.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add a test for a case when main group doesn't have icons. Since we made icons invisible when they are disabled, some paddings will not appear, so the main group visual is changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Will write them soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test is added