PivotGrid - Create FieldChooserBase only once #32364
Open
+46
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the PivotGrid widget by creating the FieldChooserBase component only once during the initial render, then updating its options on subsequent renders instead of recreating it each time. This reduces overhead and prevents accumulation of duplicate event listeners.
Changes:
- Modified
_renderContentImplto conditionally create FieldChooserBase on first drawing or update options on subsequent renders - Added a test verifying that FieldChooserBase maintains a single instance and doesn't accumulate event listeners when the dataSource is reassigned
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/pivot_grid/m_widget.ts | Modified FieldChooserBase initialization to create once and update options on re-renders |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/pivotGrid.tests.js | Added test verifying single FieldChooserBase instance with no stale references or listener accumulation |
packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/pivotGrid.tests.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.