Skip to content

fix: fix create_user_from_context_with_unknown_data_fields #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathannorris merged 2 commits into from
Jan 20, 2025
Merged

fix: fix create_user_from_context_with_unknown_data_fields #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
346253f
fix create_user_from_context_with_unknown_data_fields
WinField95 Dec 27, 2024
7c2fd60
Merge branch 'main' into fix-create-user-from-context-with-unknown-da…
jonathannorris Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devcycle_python_sdk/models/user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def create_user_from_context(
if key == "user_id":
continue

if value:
if value is not None:
if key == "email" and isinstance(value, str):
user.email = value
elif key == "name" and isinstance(value, str):
Expand Down
4 changes: 2 additions & 2 deletions test/models/test_user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def test_create_user_from_context_with_unknown_data_fields(self):
"strValue": "hello",
"intValue": 123,
"floatValue": 3.1456,
"boolValue": True,
"boolValue": False,
},
)
user = DevCycleUser.create_user_from_context(context)
Expand All @@ -143,7 +143,7 @@ def test_create_user_from_context_with_unknown_data_fields(self):
"strValue": "hello",
"intValue": 123,
"floatValue": 3.1456,
"boolValue": True,
"boolValue": False,
},
)
self.assertEqual(user.privateCustomData, None)
Expand Down
Loading