fix: initialize payloads before try block in _flush_events#112
Open
jonathannorris wants to merge 1 commit intomainfrom
Open
fix: initialize payloads before try block in _flush_events#112jonathannorris wants to merge 1 commit intomainfrom
jonathannorris wants to merge 1 commit intomainfrom
Conversation
Prevents UnboundLocalError when flush_event_queue() raises (e.g. a WASM trap), which previously masked the original error. Adds a regression test. Fixes #111
There was a problem hiding this comment.
Pull request overview
Fixes a latent UnboundLocalError in EventQueueManager._flush_events() by ensuring payloads is always defined even when flush_event_queue() raises (e.g., WASM trap), and adds a regression test to cover the exception path (Fixes #111).
Changes:
- Initialize
payloads = []before thetryblock in_flush_eventsto preventUnboundLocalErrorafter exceptions. - Add a unit test asserting
_flush_events()returns0and does not attempt to publish whenflush_event_queue()raises.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| devcycle_python_sdk/managers/event_queue_manager.py | Prevents UnboundLocalError by initializing payloads prior to the try/except around flush_event_queue(). |
| test/managers/test_event_queue_manager.py | Adds regression coverage for the exception path to ensure _flush_events() safely returns 0 and does not publish. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
suthar26
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
payloads = []before thetryblock in_flush_eventsso aflush_event_queue()exception (e.g. a WASM trap) no longer causesUnboundLocalError: local variable 'payloads' referenced before assignmenton the subsequentif payloads:checkRelated Issues
Fixes #111