Skip to content

Conversation

@jsalaber
Copy link
Contributor

@jsalaber jsalaber commented Oct 22, 2025

Changes

  • change requirement for openfeature sdk to use all future patch versions

@jsalaber jsalaber requested a review from a team as a code owner October 22, 2025 15:08
Copilot AI review requested due to automatic review settings October 22, 2025 15:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 28, 2025 15:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@suthar26 suthar26 requested a review from Copilot October 28, 2025 16:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings October 28, 2025 17:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 29, 2025 14:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

devcycle_python_sdk/open_feature_provider/provider.py:151

  • The condition logic is incorrect. The expression not isinstance(v, (str, int, float, bool)) or v is None will always be True when v is None, causing valid None values to raise an error. It should be not isinstance(v, (str, int, float, bool, type(None))) or v is not None and not isinstance(v, (str, int, float, bool)).
                if not isinstance(v, (str, int, float, bool)) or v is None:

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 29, 2025 14:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 6 changed files in this pull request and generated 12 comments.

Comments suppressed due to low confidence (1)

devcycle_python_sdk/open_feature_provider/provider.py:151

  • The logic is incorrect. The condition or v is None will always raise TypeMismatchError when v is None because the first part evaluates to True when v is None. Should be if not isinstance(v, (str, int, float, bool, type(None))) or if v is not None and not isinstance(v, (str, int, float, bool)).
                if not isinstance(v, (str, int, float, bool)) or v is None:

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@suthar26 suthar26 merged commit 2a1b1b4 into main Oct 29, 2025
18 checks passed
@suthar26 suthar26 deleted the openfeature-compatible-versions branch October 29, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants