feat: upgrade NX and migrate builds to esbuild #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
jonathannorris
force-pushed
the
feat-nx-migration
branch
from
88f354b to
3cf8690
Compare
jonathannorris
force-pushed
the
feat-nx-migration
branch
from
3cf8690 to
ef9ef69
Compare
…th their configurations and assets
…ges-router entries
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 118 out of 135 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (3)
sdk/nextjs/src/common/actions/setDebugUser.ts:1
- Using bracket notation for environment variables (
process.env['NODE_ENV']) is unnecessary. The dot notationprocess.env.NODE_ENVis more idiomatic and equally safe in TypeScript/Node.js environments.
sdk/nextjs/src/common/actions/clearDebugUser.ts:1 - Using bracket notation for environment variables (
process.env['NODE_ENV']) is unnecessary. The dot notationprocess.env.NODE_ENVis more idiomatic and equally safe in TypeScript/Node.js environments.
e2e/nextjs/app-router/tests/app-router.spec.ts:1 - The timeout was increased from 10000 to 30000ms. Consider adding a comment explaining why such a long timeout is necessary for this navigation test, as this could mask performance issues.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 120 out of 137 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JamieSinn
reviewed
Jan 2, 2026
Member
There was a problem hiding this comment.
worth copying these changes elsewhere?
Member
Author
There was a problem hiding this comment.
its basically just formatting, so probably not
JamieSinn
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@nx/js:tscbuilds to@nx/esbuild:esbuilddev-apps/next, thee2e/nextjsapps work for testing + e2e testsWhy
NX 22 removed the experimental
externaloption from@nx/js:tscthat was used to bundle internal workspace packages. These packages are not published to npm and must be bundled into the SDK dist. Additionally, NX 22 introduced breaking changes requiring updates to webpack configs, Jest configs, and project.json files.Changes
tsctoesbuildfor faster buildsproject.jsonfiles with new executor configurationsTesting