Skip to content

feat: set SSE connections as the default #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathannorris merged 1 commit into from
Jan 20, 2025
Merged

feat: set SSE connections as the default #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/devcycle/sdk/server/local/managers/EnvironmentConfigManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public boolean isConfigInitialized() {
private ProjectConfig getConfig() throws DevCycleException {
Call<ProjectConfig> config = this.configApiClient.getConfig(this.sdkKey, this.configETag, this.configLastModified);
this.config = getResponseWithRetries(config, 1);
if (this.options.isEnableBetaRealtimeUpdates()) {
if (!this.options.isDisableRealtimeUpdates()) {
try {
URI uri = new URI(this.config.getSse().getHostname() + this.config.getSse().getPath());
if (sseManager == null) {
Expand Down
11 changes: 10 additions & 1 deletion src/main/java/com/devcycle/sdk/server/local/model/DevCycleLocalOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ public class DevCycleLocalOptions implements IDevCycleOptions {

private boolean disableAutomaticEventLogging = false;

private boolean disableRealtimeUpdates = false;

/**
* @deprecated real time updates are enabled by default now
*/
@Deprecated
private boolean enableBetaRealtimeUpdates = false;

@JsonIgnore
Expand All @@ -52,7 +58,9 @@ public DevCycleLocalOptions(
boolean disableCustomEventLogging,
IDevCycleLogger customLogger,
IRestOptions restOptions,
boolean enableBetaRealtimeUpdates
@Deprecated
boolean enableBetaRealtimeUpdates,
boolean disableRealtimeUpdates
) {
this.configRequestTimeoutMs = configRequestTimeoutMs > 0 ? configRequestTimeoutMs : this.configRequestTimeoutMs;
this.configPollingIntervalMS = getConfigPollingIntervalMS(configPollingIntervalMs, configPollingIntervalMS);
Expand All @@ -67,6 +75,7 @@ public DevCycleLocalOptions(
this.customLogger = customLogger;
this.restOptions = restOptions;
this.enableBetaRealtimeUpdates = enableBetaRealtimeUpdates;
this.disableRealtimeUpdates = disableRealtimeUpdates;

if (this.flushEventQueueSize >= this.maxEventQueueSize) {
DevCycleLogger.warning("flushEventQueueSize: " + this.flushEventQueueSize + " must be smaller than maxEventQueueSize: " + this.maxEventQueueSize);
Expand Down
Loading