-
Notifications
You must be signed in to change notification settings - Fork 7
feat: update for eval reasons #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… models with eval reason
11ae7c1 to
bdff5d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the DevCycle SDK dependencies on iOS and Android, and introduces a new DevCycleEvalReason model to capture evaluation reasons for variables and features.
- Bump iOS SDK to 1.24.0 and Android SDK to 2.5.0
- Add
DevCycleEvalReasonclass and integrate it intoDVCVariableandDVCFeature - Expand unit tests to verify parsing of evaluation reasons
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/variable_test.dart | Added null-eval assertions and tests for parsing eval in variables |
| test/feature_test.dart | Added test for parsing eval in features |
| lib/dvc_variable.dart | Imported DevCycleEvalReason, updated constructor and fromCodec/fromDefault |
| lib/dvc_feature.dart | Imported DevCycleEvalReason, deprecated evalReason, added new eval |
| lib/devcycle_eval_reason.dart | Introduced DevCycleEvalReason model with fromCodec and defaultReason |
| ios/devcycle_flutter_client_sdk.podspec | Bumped DevCycle iOS SDK dependency to 1.24.0 |
| android/build.gradle | Bumped DevCycle Android SDK dependency to 2.5.0 |
Comments suppressed due to low confidence (3)
test/variable_test.dart:66
- [nitpick] Duplicate test description for
'builds variable object from a map with eval reason'. Give each test a unique name to improve readability and debugging.
test('builds variable object from a map with eval reason', () {
lib/dvc_variable.dart:49
- The
fromDefaultpath sets a default eval reason but isn’t covered by tests. Add a unit test to verify thatdefaultReasonis applied correctly.
eval: DevCycleEvalReason.defaultReason("User Not Targeted"));
lib/dvc_variable.dart:48
- mapType is undefined in
fromDefault, causing a compile error. Consider deriving the variable type fromdefaultValueor adding a parameter for the type.
.firstWhereOrNull((e) => e.toString() == "VariableType.$mapType"),
c25c628 to
b41c539
Compare
b41c539 to
c35d8b9
Compare
1.24.02.5.0