Skip to content

Conversation

@kaushalkapasi
Copy link
Contributor

@kaushalkapasi kaushalkapasi commented Jul 14, 2025

  • chore: update DevCycle iOS SDK dependency to 1.24.0
  • chore: update DevCycle Android SDK to 2.5.0
  • feat: adds model for DevCycleEvalReasons and adds it to the Feature & Variable classes & constructors

@kaushalkapasi kaushalkapasi requested review from a team and Copilot July 14, 2025 20:48

This comment was marked as outdated.

@kaushalkapasi kaushalkapasi requested a review from Copilot July 14, 2025 21:04

This comment was marked as outdated.

@kaushalkapasi kaushalkapasi force-pushed the chore-update-for-eval-reasons branch from 11ae7c1 to bdff5d2 Compare July 14, 2025 21:10
@kaushalkapasi kaushalkapasi requested a review from Copilot July 14, 2025 21:10

This comment was marked as outdated.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the DevCycle SDK dependencies on iOS and Android, and introduces a new DevCycleEvalReason model to capture evaluation reasons for variables and features.

  • Bump iOS SDK to 1.24.0 and Android SDK to 2.5.0
  • Add DevCycleEvalReason class and integrate it into DVCVariable and DVCFeature
  • Expand unit tests to verify parsing of evaluation reasons

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/variable_test.dart Added null-eval assertions and tests for parsing eval in variables
test/feature_test.dart Added test for parsing eval in features
lib/dvc_variable.dart Imported DevCycleEvalReason, updated constructor and fromCodec/fromDefault
lib/dvc_feature.dart Imported DevCycleEvalReason, deprecated evalReason, added new eval
lib/devcycle_eval_reason.dart Introduced DevCycleEvalReason model with fromCodec and defaultReason
ios/devcycle_flutter_client_sdk.podspec Bumped DevCycle iOS SDK dependency to 1.24.0
android/build.gradle Bumped DevCycle Android SDK dependency to 2.5.0
Comments suppressed due to low confidence (3)

test/variable_test.dart:66

  • [nitpick] Duplicate test description for 'builds variable object from a map with eval reason'. Give each test a unique name to improve readability and debugging.
  test('builds variable object from a map with eval reason', () {

lib/dvc_variable.dart:49

  • The fromDefault path sets a default eval reason but isn’t covered by tests. Add a unit test to verify that defaultReason is applied correctly.
        eval: DevCycleEvalReason.defaultReason("User Not Targeted"));

lib/dvc_variable.dart:48

  • mapType is undefined in fromDefault, causing a compile error. Consider deriving the variable type from defaultValue or adding a parameter for the type.
            .firstWhereOrNull((e) => e.toString() == "VariableType.$mapType"),

@kaushalkapasi kaushalkapasi force-pushed the chore-update-for-eval-reasons branch from c25c628 to b41c539 Compare July 15, 2025 15:32
@kaushalkapasi kaushalkapasi force-pushed the chore-update-for-eval-reasons branch from b41c539 to c35d8b9 Compare July 15, 2025 15:35
@kaushalkapasi kaushalkapasi merged commit 6ddf972 into main Jul 15, 2025
4 checks passed
@kaushalkapasi kaushalkapasi deleted the chore-update-for-eval-reasons branch July 15, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants