-
Notifications
You must be signed in to change notification settings - Fork 4
chore: update mcp sdk, oauth provider, and agents packages #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates several dependencies across the project, including major updates to the MCP SDK, agents library, and OAuth provider. It also includes minor code cleanup to remove unused variables and improve error handling.
Key Changes:
- Updates
@modelcontextprotocol/sdkfrom^1.18.1to^1.20.2across the workspace - Updates
agentsfrom^0.1.4to^0.2.19with breaking changes in peer dependencies - Updates
@cloudflare/workers-oauth-providerfrom^0.0.10to^0.0.13 - Removes unused imports and function parameters
- Improves error handling syntax in test utilities
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Massive dependency update with numerous package additions/removals and version updates |
| package.json | Updates MCP SDK to version 1.20.2 |
| mcp-worker/package.json | Updates OAuth provider and agents library versions |
| mcp-worker/src/index.ts | Removes unused OAuthHelpers import |
| mcp-worker/src/auth.ts | Removes unused clientUri variable |
| mcp-worker/src/consentScreen.ts | Removes unused function parameters clientUri and redirectUri |
| test-utils/init.js | Improves empty catch block with explanatory comment |
| oclif.manifest.json | Version bump from 6.1.1 to 6.1.2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| // Extract client information for the consent screen | ||
| const clientName = client.clientName || client.clientId | ||
| const clientLogo = client.logoUri || '' // No default logo |
Copilot
AI
Oct 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The removed clientUri variable was assigned from client.clientUri || '#', but the code comment indicates 'No default logo' for the clientLogo assignment. Consider verifying that the 'No default logo' comment is still accurate and appropriately placed. The comment placement may be misleading as it appears after the clientLogo assignment when it might have been related to the removed clientUri line.
| const clientLogo = client.logoUri || '' // No default logo | |
| const clientLogo = client.logoUri || '' // Defaults to empty string if no logoUri is provided |
| } catch { | ||
| // ts-node may not be available in all environments, ignore error |
Copilot
AI
Oct 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the added comment improves clarity, the empty catch block silently swallows all errors from require('ts-node/register'), not just module-not-found errors. Consider catching and checking for the specific error type (MODULE_NOT_FOUND) to avoid hiding unexpected errors during ts-node initialization.
| } catch { | |
| // ts-node may not be available in all environments, ignore error | |
| } catch (err) { | |
| // ts-node may not be available in all environments, ignore MODULE_NOT_FOUND error | |
| if (!err || err.code !== 'MODULE_NOT_FOUND') throw err; |
Updates MCP-related dependencies to latest versions and fixes linting errors:
Also fixes linting errors (empty catch block, unused imports/parameters).