Skip to content

Conversation

@jonathannorris
Copy link
Member

Updates MCP-related dependencies to latest versions and fixes linting errors:

  • @modelcontextprotocol/sdk: 1.18.1 → 1.20.2
  • @cloudflare/workers-oauth-provider: 0.0.10 → 0.0.13
  • agents: 0.1.4 → 0.2.19

Also fixes linting errors (empty catch block, unused imports/parameters).

@jonathannorris jonathannorris requested a review from a team as a code owner October 30, 2025 18:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates several dependencies across the project, including major updates to the MCP SDK, agents library, and OAuth provider. It also includes minor code cleanup to remove unused variables and improve error handling.

Key Changes:

  • Updates @modelcontextprotocol/sdk from ^1.18.1 to ^1.20.2 across the workspace
  • Updates agents from ^0.1.4 to ^0.2.19 with breaking changes in peer dependencies
  • Updates @cloudflare/workers-oauth-provider from ^0.0.10 to ^0.0.13
  • Removes unused imports and function parameters
  • Improves error handling syntax in test utilities

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
yarn.lock Massive dependency update with numerous package additions/removals and version updates
package.json Updates MCP SDK to version 1.20.2
mcp-worker/package.json Updates OAuth provider and agents library versions
mcp-worker/src/index.ts Removes unused OAuthHelpers import
mcp-worker/src/auth.ts Removes unused clientUri variable
mcp-worker/src/consentScreen.ts Removes unused function parameters clientUri and redirectUri
test-utils/init.js Improves empty catch block with explanatory comment
oclif.manifest.json Version bump from 6.1.1 to 6.1.2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


// Extract client information for the consent screen
const clientName = client.clientName || client.clientId
const clientLogo = client.logoUri || '' // No default logo
Copy link

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The removed clientUri variable was assigned from client.clientUri || '#', but the code comment indicates 'No default logo' for the clientLogo assignment. Consider verifying that the 'No default logo' comment is still accurate and appropriately placed. The comment placement may be misleading as it appears after the clientLogo assignment when it might have been related to the removed clientUri line.

Suggested change
const clientLogo = client.logoUri || '' // No default logo
const clientLogo = client.logoUri || '' // Defaults to empty string if no logoUri is provided

Copilot uses AI. Check for mistakes.
Comment on lines +12 to +13
} catch {
// ts-node may not be available in all environments, ignore error
Copy link

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the added comment improves clarity, the empty catch block silently swallows all errors from require('ts-node/register'), not just module-not-found errors. Consider catching and checking for the specific error type (MODULE_NOT_FOUND) to avoid hiding unexpected errors during ts-node initialization.

Suggested change
} catch {
// ts-node may not be available in all environments, ignore error
} catch (err) {
// ts-node may not be available in all environments, ignore MODULE_NOT_FOUND error
if (!err || err.code !== 'MODULE_NOT_FOUND') throw err;

Copilot uses AI. Check for mistakes.
@jonathannorris jonathannorris merged commit 03558b7 into main Oct 30, 2025
14 checks passed
@jonathannorris jonathannorris deleted the chore-update-mcp-packages branch October 30, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants