-
Notifications
You must be signed in to change notification settings - Fork 4
feat: update MCP tool params to inheriet all zodSchema parameters #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
devcycle-mcp-server | 5961f3b | Sep 16 2025, 08:06 PM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the MCP types to auto-inherit parameters from zodSchemas instead of manually redefining them, with the ability to override parameters that need specific descriptions.
- Replaces manual object creation with
.extend()to inherit all parameters from base schemas - Adds missing parameters (persistent, tags) to variable schemas and updates their descriptions
- Moves GetProjectsParams definition from zodClientAPI.ts to zodSchemas.ts for better organization
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/mcp/types.ts | Updates all MCP argument schemas to use .extend() for automatic parameter inheritance |
| src/commands/projects/get.ts | Updates import path for GetProjectsParams |
| src/api/zodSchemas.ts | Adds GetProjectsParams definition and various schema improvements |
| src/api/zodClientAPI.ts | Removes GetProjectsParams definition (moved to zodSchemas.ts) |
| src/api/schemas.ts | Updates import path for GetProjectsParams |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
5d83e55 to
c4d55ca
Compare
c192137 to
17b64db
Compare
600853a to
f215dce
Compare
a2ff02f to
4a9905d
Compare
f215dce to
fe2c5a9
Compare
4a9905d to
a37901b
Compare
64f5e81 to
9fc7a16
Compare
a37901b to
6807c80
Compare
6807c80 to
5961f3b
Compare
types.tsto by default auto-inherit new params from thezodSchemas.tsand just overwrite params that need descriptions.z.record(z.unknown())instead ofz.object({}).partial().passthrough()