Skip to content

Conversation

@jonathannorris
Copy link
Member

@jonathannorris jonathannorris commented Sep 16, 2025

  • Updated the MCP types.ts to by default auto-inherit new params from the zodSchemas.ts and just overwrite params that need descriptions.
  • use z.record(z.unknown()) instead of z.object({}).partial().passthrough()

@jonathannorris jonathannorris requested a review from a team as a code owner September 16, 2025 19:26
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 16, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
devcycle-mcp-server 5961f3b Sep 16 2025, 08:06 PM

@jonathannorris jonathannorris requested review from JamieSinn, Copilot, jsalaber and kaushalkapasi and removed request for a team September 16, 2025 19:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MCP types to auto-inherit parameters from zodSchemas instead of manually redefining them, with the ability to override parameters that need specific descriptions.

  • Replaces manual object creation with .extend() to inherit all parameters from base schemas
  • Adds missing parameters (persistent, tags) to variable schemas and updates their descriptions
  • Moves GetProjectsParams definition from zodClientAPI.ts to zodSchemas.ts for better organization

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/mcp/types.ts Updates all MCP argument schemas to use .extend() for automatic parameter inheritance
src/commands/projects/get.ts Updates import path for GetProjectsParams
src/api/zodSchemas.ts Adds GetProjectsParams definition and various schema improvements
src/api/zodClientAPI.ts Removes GetProjectsParams definition (moved to zodSchemas.ts)
src/api/schemas.ts Updates import path for GetProjectsParams

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jonathannorris jonathannorris force-pushed the docs-update-delete-variable-description branch from 5d83e55 to c4d55ca Compare September 16, 2025 19:35
@jonathannorris jonathannorris force-pushed the feat-variable-tool-schema-updates branch 2 times, most recently from c192137 to 17b64db Compare September 16, 2025 19:48
@jonathannorris jonathannorris force-pushed the docs-update-delete-variable-description branch 2 times, most recently from 600853a to f215dce Compare September 16, 2025 19:50
@jonathannorris jonathannorris force-pushed the feat-variable-tool-schema-updates branch 2 times, most recently from a2ff02f to 4a9905d Compare September 16, 2025 19:53
@jonathannorris jonathannorris force-pushed the docs-update-delete-variable-description branch from f215dce to fe2c5a9 Compare September 16, 2025 19:53
@jonathannorris jonathannorris force-pushed the feat-variable-tool-schema-updates branch from 4a9905d to a37901b Compare September 16, 2025 19:55
@jonathannorris jonathannorris force-pushed the docs-update-delete-variable-description branch 2 times, most recently from 64f5e81 to 9fc7a16 Compare September 16, 2025 20:01
@jonathannorris jonathannorris force-pushed the feat-variable-tool-schema-updates branch from a37901b to 6807c80 Compare September 16, 2025 20:01
Base automatically changed from docs-update-delete-variable-description to main September 16, 2025 20:03
@jonathannorris jonathannorris force-pushed the feat-variable-tool-schema-updates branch from 6807c80 to 5961f3b Compare September 16, 2025 20:03
@jonathannorris jonathannorris enabled auto-merge (squash) September 16, 2025 20:03
@jonathannorris jonathannorris merged commit 186a0e7 into main Sep 16, 2025
8 of 9 checks passed
@jonathannorris jonathannorris deleted the feat-variable-tool-schema-updates branch September 16, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants