-
Notifications
You must be signed in to change notification settings - Fork 4
feat: update all schemas, all schemas in zodSchemas.ts now #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
devcycle-mcp-server | 4335d4e | Sep 16 2025, 07:56 PM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates all Zod schemas into a single file (zodSchemas.ts) and removes schema definitions from zodClientAPI.ts. The purpose is to centralize schema management and eliminate duplication between schema files.
- Updated schema imports across multiple files to use the centralized
zodSchemas.ts - Enhanced targeting prompts to support
platformVersioncomparison operators - Moved all schema definitions from
zodClientAPI.tstozodSchemas.tsfor centralized management
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/ui/prompts/targetingPrompts.ts |
Added support for platformVersion subType in comparator choices |
src/mcp/types.ts |
Updated imports to use schemas from zodSchemas.ts instead of zodClientAPI.ts |
src/api/zodSchemas.ts |
Major expansion with all schema definitions and MCP compatibility documentation |
src/api/zodClientAPI.ts |
Removed all schema definitions and updated imports to use zodSchemas.ts |
src/api/schemas.ts |
Updated imports to use schemas from zodSchemas.ts instead of zodClientAPI.ts |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| values: z.array(z.string()).optional(), | ||
| type: z.literal('user').default('user'), | ||
| subType: z.literal('appVersion').default('appVersion'), | ||
| subType: z.literal('platformVersion').default('platformVersion'), |
Copilot
AI
Sep 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UserPlatformVersionFilter schema has an incorrect subType default value. Based on the schema name and the fix in targetingPrompts.ts, this should be 'platformVersion' but the field name suggests it should match the pattern used in UserAppVersionFilter.
4774129 to
d7c3e68
Compare
6d9f692 to
834c084
Compare
d7c3e68 to
ccabe8f
Compare
834c084 to
83ef91d
Compare
ccabe8f to
ed788eb
Compare
83ef91d to
07eda7b
Compare
ed788eb to
4335d4e
Compare
Update all schemas to the newly generated ones, remove all schemas from
zodClientAPI.ts, all zod schemas are inzodSchemas.ts.