Skip to content

Conversation

@jonathannorris
Copy link
Member

@jonathannorris jonathannorris commented Sep 16, 2025

Update all schemas to the newly generated ones, remove all schemas from zodClientAPI.ts, all zod schemas are in zodSchemas.ts.

@jonathannorris jonathannorris requested a review from a team as a code owner September 16, 2025 17:49
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 16, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
devcycle-mcp-server 4335d4e Sep 16 2025, 07:56 PM

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates all Zod schemas into a single file (zodSchemas.ts) and removes schema definitions from zodClientAPI.ts. The purpose is to centralize schema management and eliminate duplication between schema files.

  • Updated schema imports across multiple files to use the centralized zodSchemas.ts
  • Enhanced targeting prompts to support platformVersion comparison operators
  • Moved all schema definitions from zodClientAPI.ts to zodSchemas.ts for centralized management

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/ui/prompts/targetingPrompts.ts Added support for platformVersion subType in comparator choices
src/mcp/types.ts Updated imports to use schemas from zodSchemas.ts instead of zodClientAPI.ts
src/api/zodSchemas.ts Major expansion with all schema definitions and MCP compatibility documentation
src/api/zodClientAPI.ts Removed all schema definitions and updated imports to use zodSchemas.ts
src/api/schemas.ts Updated imports to use schemas from zodSchemas.ts instead of zodClientAPI.ts

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

values: z.array(z.string()).optional(),
type: z.literal('user').default('user'),
subType: z.literal('appVersion').default('appVersion'),
subType: z.literal('platformVersion').default('platformVersion'),
Copy link

Copilot AI Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UserPlatformVersionFilter schema has an incorrect subType default value. Based on the schema name and the fix in targetingPrompts.ts, this should be 'platformVersion' but the field name suggests it should match the pattern used in UserAppVersionFilter.

Copilot uses AI. Check for mistakes.
@jonathannorris jonathannorris force-pushed the feat-update-more-schemas branch from 4774129 to d7c3e68 Compare September 16, 2025 19:35
@jonathannorris jonathannorris force-pushed the feat-update-more-schemas branch from d7c3e68 to ccabe8f Compare September 16, 2025 19:48
@jonathannorris jonathannorris force-pushed the feat-update-more-schemas branch from ccabe8f to ed788eb Compare September 16, 2025 19:50
Base automatically changed from feat-update-zod to main September 16, 2025 19:52
@jonathannorris jonathannorris force-pushed the feat-update-more-schemas branch from ed788eb to 4335d4e Compare September 16, 2025 19:53
@jonathannorris jonathannorris enabled auto-merge (squash) September 16, 2025 19:53
@jonathannorris jonathannorris merged commit a2d29ab into main Sep 16, 2025
8 of 9 checks passed
@jonathannorris jonathannorris deleted the feat-update-more-schemas branch September 16, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants