feat: Cleanup all feature schemas #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
devcycle-mcp-server | f4df05d | Sep 16 2025, 07:51 PM |
jonathannorris
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates schema definitions into a single source of truth by migrating from zodClientV2.ts to zodSchemas.ts. The primary purpose is to cleanup feature schema organization and eliminate duplicate definitions.
Key changes include:
- Rename
zodClientV2.tstozodSchemas.tsfor better organization - Update imports across the codebase to use the new schema file
- Remove duplicate
UpdateFeatureStatusDtodefinition fromschemas.ts - Add new feature status update endpoint to the API client
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mcp/types.ts | Updates import path and adds minimum length validation for feature keys |
| src/mcp/tools/featureTools.ts | Removes commented out variation and targeting handler functions |
| src/commands/projects/get.ts | Updates import path from zodClient to zodClientAPI |
| src/commands/features/update.test.ts | Simplifies test expectations by removing extra properties from request bodies |
| src/api/zodSchemas.ts | New file containing consolidated schema definitions |
| src/api/zodClientAPI.ts | Updates imports and adds new feature status endpoint |
| src/api/schemas.ts | Removes duplicate UpdateFeatureStatusDto and updates imports |
| src/api/apiClient.ts | Updates import path to use zodClientAPI |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JamieSinn
approved these changes
Sep 16, 2025
jonathannorris
force-pushed
the
fix-typescript-inference-issues
branch
from
a4a94fb to
b7b93c4
Compare
jonathannorris
force-pushed
the
feat-more-schema-updates
branch
from
0299115 to
1ece414
Compare
- Add /v2/projects/:project/features/:feature/status PATCH endpoint to zodClient.ts - Export UpdateFeatureStatusDto schema from zodClientV2.ts - Remove duplicate UpdateFeatureStatusDto from schemas.ts and import from zodClientV2.ts - Maintain single source of truth for UpdateFeatureStatusDto schema
- Remove extra properties (headless, whichFields, listPromptOption) from HTTP mock expectations - These properties were filtered out by Zod validation in the actual command - All tests now pass with correct request body matching
jonathannorris
force-pushed
the
feat-more-schema-updates
branch
from
1ece414 to
f4df05d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/v2/projects/:project/features/:feature/statusPATCH endpoint to zodClient.tsUpdateFeatureStatusDtoschemazodClientV2.ts->zodSchemas.ts, going to havezodClientAPI.tsfile for the API, andzodSchemas.tsfor the schema definitions.