feat: Use Feature V2 API schemas from updated OpenAPI specification, cleanup tools #512

jonathannorris · 2025-09-12T19:09:26Z

This PR introduces updated API schemas generated from the latest OpenAPI specification while maintaining backward compatibility and resolving TypeScript compilation issues. The new schemas in the zodClientV2.ts file are just being used for the /v2/features endpoints for now, in further PRs will update the rest of the endpoints. Also removed all the

Changes

✅ New V2 Schemas: Add src/api/zodClientV2.ts with updated Zod schemas from latest OpenAPI spec
✅ Schema Generation: Update script to generate V2 schemas alongside existing V1 schemas for selective migration
✅ TypeScript Fixes: Implement intermediate type aliases to resolve inference issues with large schema definitions. Also refactored schemas to fix TS large schema generation issues.
✅ Type Safety: Replace any types with proper schema-derived interfaces (Project, Environment, Variable, etc.)
✅ Cleanup MCP: Removed variation and targeting MCP tools, just relying on PATCH feature endpoint.

Migration Strategy

V2 schemas are available for selective adoption alongside existing V1 schemas, allowing gradual migration without breaking existing functionality.

cloudflare-workers-and-pages · 2025-09-12T20:56:46Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
✅ Deployment successful! View logs	devcycle-mcp-server	`b7b93c4`	Sep 16 2025, 07:38 PM

Copilot

Pull Request Overview

This PR introduces updated API schemas generated from the latest OpenAPI specification while maintaining backward compatibility and cleaning up MCP tools. It updates V2 schemas for selective migration, fixes TypeScript compilation issues, and consolidates feature management functionality by removing specific variation and targeting tools.

Updates API schemas from latest OpenAPI spec with V2 schemas generated in zodClientV2.ts
Adds explicit type annotations for TypeScript compatibility and removes redundant MCP tools
Removes variation and targeting specific MCP tools to rely on the main PATCH feature endpoint

Reviewed Changes

Copilot reviewed 27 out of 30 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/api/zodClient.ts	Updates schema references to use V2 definitions and adds TypeScript workarounds for large schema inference
src/api/schemas.ts	Refactors to use direct imports from zodClient instead of schemas object
src/mcp/types.ts	Updates MCP tool schema references to use direct imports instead of schemas object
src/mcp/tools/featureTools.ts	Comments out variation and targeting specific tools, consolidating to main feature endpoint
src/ui/prompts/*.ts	Adds explicit type annotations for map callbacks to improve TypeScript inference
src/commands/*/.ts	Adds type imports and explicit type annotations for better type safety

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/mcp/tools/featureTools.ts

src/commands/variables/create.ts

Copilot

Pull Request Overview

Copilot reviewed 27 out of 30 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/commands/variables/create.ts

src/api/zodClient.ts

Copilot

Pull Request Overview

Copilot reviewed 27 out of 30 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/mcp/tools/featureTools.ts

src/api/zodClient.ts

JamieSinn · 2025-09-15T20:37:35Z

src/mcp/tools/featureTools.ts

+    // serverInstance.registerToolWithErrorHandling(
+    //     'fetch_feature_variations',
+    //     {
+    //         description: [
+    //             'Get a list of variations for a feature.',
+    //             'Include dashboard link in the response.',
+    //         ].join('\n'),
+    //         annotations: {
+    //             title: 'Get Feature Variations',
+    //             readOnlyHint: true,
+    //         },
+    //         inputSchema: ListVariationsArgsSchema.shape,
+    //     },
+    //     async (args: any) => {
+    //         const validatedArgs = ListVariationsArgsSchema.parse(args)
+    //         return await fetchFeatureVariationsHandler(validatedArgs, apiClient)
+    //     },
+    // )
+
+    // serverInstance.registerToolWithErrorHandling(
+    //     'create_feature_variation',
+    //     {
+    //         description: [
+    //             'Create a new variation within a feature.',
+    //             'Include dashboard link in the response.',
+    //         ].join('\n'),
+    //         annotations: {
+    //             title: 'Create Feature Variation',
+    //         },
+    //         inputSchema: CreateVariationArgsSchema.shape,
+    //     },
+    //     async (args: any) => {
+    //         const validatedArgs = CreateVariationArgsSchema.parse(args)
+    //         return await createFeatureVariationHandler(validatedArgs, apiClient)
+    //     },
+    // )
+
+    // serverInstance.registerToolWithErrorHandling(
+    //     'update_feature_variation',
+    //     {
+    //         description: [
+    //             'Update an existing variation by key.',
+    //             '⚠️ WARNING: Updating a feature variation may affect production environments.',
+    //             'Include dashboard link in the response.',
+    //         ].join('\n'),
+    //         annotations: {
+    //             title: 'Update Feature Variation',
+    //             destructiveHint: true,
+    //         },
+    //         inputSchema: UpdateVariationArgsSchema.shape,
+    //     },
+    //     async (args: any) => {
+    //         const validatedArgs = UpdateVariationArgsSchema.parse(args)
+    //         return await updateFeatureVariationHandler(validatedArgs, apiClient)
+    //     },
+    // )
+
+    // serverInstance.registerToolWithErrorHandling(
+    //     'set_feature_targeting',
+    //     {
+    //         description: [
+    //             'Set targeting status for a feature in an environment.',
+    //             '⚠️ IMPORTANT: Always confirm with the user before making changes to production environments (environments where type = "production").',
+    //             'Include dashboard link in the response.',
+    //         ].join('\n'),
+    //         annotations: {
+    //             title: 'Set Feature Targeting',
+    //             destructiveHint: true,
+    //         },
+    //         inputSchema: SetFeatureTargetingArgsSchema.shape,
+    //     },
+    //     async (args: any) => {
+    //         const validatedArgs = SetFeatureTargetingArgsSchema.parse(args)
+    //         return await setFeatureTargetingHandler(validatedArgs, apiClient)
+    //     },
+    // )
+
+    // serverInstance.registerToolWithErrorHandling(
+    //     'list_feature_targeting',
+    //     {
+    //         description: [
+    //             'List feature configurations (targeting rules) for a feature.',
+    //             'Include dashboard link in the response.',
+    //         ].join('\n'),
+    //         annotations: {
+    //             title: 'List Feature Targeting Rules',
+    //             readOnlyHint: true,
+    //         },
+    //         inputSchema: ListFeatureTargetingArgsSchema.shape,
+    //     },
+    //     async (args: any) => {
+    //         const validatedArgs = ListFeatureTargetingArgsSchema.parse(args)
+    //         return await listFeatureTargetingHandler(validatedArgs, apiClient)
+    //     },
+    // )
+
+    // serverInstance.registerToolWithErrorHandling(
+    //     'update_feature_targeting',
+    //     {
+    //         description: [
+    //             'Update feature configuration (targeting rules) for a feature in an environment.',
+    //             '⚠️ IMPORTANT: Always confirm with the user before making changes to production environments (environments where type = "production").',
+    //             'Include dashboard link in the response.',
+    //         ].join('\n'),
+    //         annotations: {
+    //             title: 'Update Feature Targeting Rules',
+    //             destructiveHint: true,
+    //         },
+    //         inputSchema: UpdateFeatureTargetingArgsSchema.shape,
+    //     },
+    //     async (args: any) => {
+    //         const validatedArgs = UpdateFeatureTargetingArgsSchema.parse(args)
+    //         return await updateFeatureTargetingHandler(validatedArgs, apiClient)
+    //     },
+    // )


keeping them for now as I'm verifying the functionality of these tools, but yea there are a couple of these that I'm going to cleanup at the end of all these branches.

JamieSinn · 2025-09-15T20:37:48Z

src/mcp/types.ts

+    // summary: UpdateFeatureDto.shape.summary.describe(
+    //     'Updated feature summary',
+    // ),
+    // staleness: UpdateFeatureDto.shape.staleness.describe(
+    //     'Updated feature staleness configuration',
+    // ),


mcp-worker/tsconfig.json

jonathannorris · 2025-09-16T19:34:47Z

@JamieSinn can I get a review on this root PR?

- Add intermediate type aliases to break complex Zodios endpoint inference chains - Replace 'any' callback parameters with proper TypeScript interfaces (Project, Environment, Variable, etc.) - Add missing FeatureOverride type export to zodClient schemas - Add zod-to-json-schema dependency for schema comparison tools - Maintain full type safety throughout codebase while working around TS inference limits

- Update schemas.ts to import schemas directly instead of from schemas object - Fix zodClient export syntax by using proper alias syntax - Unify Variable and Feature schemas by importing from zodClientV2 - Fix schema compatibility issues between zodClient and zodClientV2 - Update all schema references in commands and MCP types - Add type casting where needed to resolve remaining compatibility issues

- Fix Zodios schema validation errors by updating test fixtures - Add missing required fields (tags, publicName) to mock data - Update HTTP request matching in Nock expectations for features update - Fix MCP server test tool count expectations (21 vs 25+ tools) - Update test snapshots to reflect schema changes - Resolve all 187 test suite failures caused by stricter type validation

…g safety

JamieSinn

Stacked prs should be merged bottom up. This is just insanely huge now

jonathannorris · 2025-09-16T19:45:17Z

@JamieSinn nothing has been merged into this one, this was the original one before I figured out what I was going to do and started stacking.

JamieSinn · 2025-09-16T19:46:37Z

Ah - i thought the updates were from merges

jonathannorris requested a review from a team as a code owner September 12, 2025 19:09

jonathannorris changed the title ~~t show --name-only HEAD~~ feat: Add V2 API schemas from updated OpenAPI specification Sep 12, 2025

jonathannorris marked this pull request as draft September 12, 2025 19:12

jonathannorris changed the title ~~feat: Add V2 API schemas from updated OpenAPI specification~~ feat: Use Feature V2 API schemas from updated OpenAPI specification, cleanup tools Sep 15, 2025

jonathannorris force-pushed the fix-typescript-inference-issues branch from 41400a7 to 3f55ddb Compare September 15, 2025 19:31

jonathannorris marked this pull request as ready for review September 15, 2025 19:31

jonathannorris requested a review from Copilot September 15, 2025 19:31

Copilot AI reviewed Sep 15, 2025

View reviewed changes

src/mcp/tools/featureTools.ts Outdated Show resolved Hide resolved

src/commands/variables/create.ts Outdated Show resolved Hide resolved

jonathannorris requested a review from Copilot September 15, 2025 20:30

Copilot AI reviewed Sep 15, 2025

View reviewed changes

src/commands/variables/create.ts Outdated Show resolved Hide resolved

src/api/zodClient.ts Show resolved Hide resolved

jonathannorris requested review from JamieSinn, Copilot, jsalaber and kaushalkapasi September 15, 2025 20:35

Copilot AI reviewed Sep 15, 2025

View reviewed changes

src/mcp/tools/featureTools.ts Show resolved Hide resolved

src/api/zodClient.ts Show resolved Hide resolved

JamieSinn reviewed Sep 15, 2025

View reviewed changes

mcp-worker/tsconfig.json Show resolved Hide resolved

jonathannorris requested a review from JamieSinn September 16, 2025 17:52

jonathannorris added 10 commits September 16, 2025 15:35

feat: try commenting out variations and targeting tools

e9bd44b

feat: add update feature params

182a992

fix: improve typescript inference and remove unused schemas

b860b3c

fix: comment out additional unused project schemas

c754e5f

chore: add code comment

9fd1ee6

chore: cleanup

16e6995

chore: schema fixes

bcb1574

jonathannorris added 3 commits September 16, 2025 15:35

feat: update tool descriptions

eaf9e5c

fix: address copilot review comments - fix typos and optional chainin…

7523498

…g safety

chore: fix PR comment

b7b93c4

jonathannorris force-pushed the fix-typescript-inference-issues branch from a4a94fb to b7b93c4 Compare September 16, 2025 19:35

JamieSinn approved these changes Sep 16, 2025

View reviewed changes

jonathannorris merged commit 46fe458 into main Sep 16, 2025
9 checks passed

jonathannorris deleted the fix-typescript-inference-issues branch September 16, 2025 19:48

feat: Use Feature V2 API schemas from updated OpenAPI specification, cleanup tools #512

feat: Use Feature V2 API schemas from updated OpenAPI specification, cleanup tools #512

Uh oh!

Conversation

jonathannorris commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Migration Strategy

Uh oh!

cloudflare-workers-and-pages bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Workers

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

JamieSinn Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

jonathannorris Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

JamieSinn Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jonathannorris commented Sep 16, 2025

Uh oh!

JamieSinn left a comment

Choose a reason for hiding this comment

Uh oh!

jonathannorris commented Sep 16, 2025

Uh oh!

JamieSinn commented Sep 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

jonathannorris commented Sep 12, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Sep 12, 2025 •

edited

Loading