Skip to content

Conversation

@jonathannorris
Copy link
Member

@jonathannorris jonathannorris commented Sep 10, 2025

Changes

  • ✅ Updated updateFeatureStatus to use /v2/projects/{project}/features/{feature}/status
  • ✅ Updated generatePaginatedFeatureUrl to use /v2/projects/{project}/features for paginated feature listing
  • ✅ Updated test mocks to match new v2 endpoints

Impact

  • Migrates feature status updates and paginated feature fetching to the modern v2 API
  • Maintains backward compatibility for existing functionality
  • All tests passing (187/187 ✅)

@jonathannorris jonathannorris requested a review from a team as a code owner September 10, 2025 20:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates feature-related API endpoints from v1 to v2, updating both the feature status update endpoint and the paginated features listing endpoint.

  • Updates updateFeatureStatus function to use the v2 API endpoint
  • Updates generatePaginatedFeatureUrl helper to generate v2 API URLs
  • Updates corresponding test mocks to reflect the new v2 endpoints

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/api/features.ts Updates API endpoint URLs from v1 to v2 for feature status updates and paginated feature listing
src/commands/generate/types.test.ts Updates test mocks to use v2 endpoints for feature listing requests

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JamieSinn
Copy link
Member

Doesn't this have a different response/object model?

@suthar26
Copy link
Contributor

@JamieSinn its the same as the feature object, it was actually wrong before since it had configurations field which does not support

@jonathannorris jonathannorris merged commit 82c5acc into main Sep 11, 2025
8 checks passed
@jonathannorris jonathannorris deleted the feat-update-features-endpoints-to-v2 branch September 11, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants