-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add ably event publishing for mcp worker installs #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds real-time event publishing to notify the dashboard when users successfully complete OAuth authentication with the hosted MCP Worker. The implementation uses Ably for publishing events to organization-specific channels.
- Added Ably event publishing for MCP worker OAuth completion
- Created centralized telemetry module with error handling
- Updated configuration and documentation for new dependency
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
mcp-worker/src/ably.ts |
New module for publishing MCP install events to Ably channels |
mcp-worker/src/auth.ts |
Added event publishing to OAuth callback flow |
mcp-worker/package.json |
Added Ably dependency |
mcp-worker/wrangler.toml |
Added ABLY_API_KEY configuration comment and enabled AI binding |
mcp-worker/README.md |
Documented new event publishing functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Add Ably Event Publishing for MCP Worker Installs
This PR adds real-time event publishing to the dashboard when users successfully install and authenticate with the hosted MCP Worker.
Changes
mcp-installevents to Ably on successful OAuth completion${orgId}-mcp-installAbly.Rest.Promisefollowing existing EventForwardingObject patternwaitUntil()to avoid blocking OAuth flowFiles Modified
mcp-worker/src/telemetry.ts- New centralized telemetry modulemcp-worker/src/auth.ts- Simplified OAuth callback with event publishingmcp-worker/package.json- Added Ably dependencymcp-worker/wrangler.toml- Environment variable commentsmcp-worker/worker-configuration.d.ts- AddedABLY_API_KEYtypingmcp-worker/README.md- Updated documentationConfiguration Required
ABLY_API_KEYsecret in Cloudflare Workers dashboard