-
Notifications
You must be signed in to change notification settings - Fork 4
Update mcp auth page #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Update mcp auth page #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdruxerman
commented
Jul 31, 2025
- updated the MCP auth page to align to our auth0 auth pages
…_targeting_overrides
…e_feature_variation tool calls
* feat: add result endpoints to MCP tools * fix: yarn build * fix: revert feature tools changes
* feat: add custom properties tools * fix: add missing custom properties type schemas
…471) * feat: add destructive hints, titles, and readonly hints to mcp tools * fix: update tool descriptions
* test: add comprehensive core server tests for mcp * test: address pr comments on mcp server test structure - Remove redundant setRequestHandlerStub variable - Fix test isolation by removing prototype stubs from beforeEach - Improve dependency injection using Object.defineProperty - Add proper formatting for multi-line statements
* test: add comprehensive core server tests for mcp * test: address pr comments on mcp server test structure - Remove redundant setRequestHandlerStub variable - Fix test isolation by removing prototype stubs from beforeEach - Improve dependency injection using Object.defineProperty - Add proper formatting for multi-line statements * test: add minimal authentication tests for MCP server * test: improve mcp auth tests with dependency injection and proper stubbing
* test: add minimal mcp api client tests * fix: address pr feedback for type safety improvements * test: improve test assertion formatting for readability
- Create MCPToolRegistry interface and class for tool management - Add IDevCycleApiClient interface for API abstraction - Refactor project tools to use registry pattern - Add central tool registration coordination - Maintain backward compatibility with legacy exports - Add comprehensive registry tests (7 test cases) This enables sharing tool implementations between local and remote MCP servers while preserving existing functionality. Phase 1.1 of Cloudflare Worker plan.
- Add dedicated API interface module (src/mcp/api/interface.ts) - Create IDevCycleApiClient, IAuthContext, and factory interfaces - Implement LocalDevCycleApiClient wrapping existing DevCycleApiClient - Add WorkerDevCycleApiClient skeleton for Cloudflare Worker support - Move interface from registry to dedicated API module - Add comprehensive interface tests (8 test cases) - Create API abstraction documentation This enables same tool implementations to work with different auth strategies: - Local: file system, environment variables, SSO tokens - Worker: OAuth JWT tokens from Cloudflare Worker context Phase 1.2 of Cloudflare Worker plan.
…acy exports single source of truth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.