new members subsciption end date

src/DevBetterWeb.Core/Entities/Member.cs

@@ -346,7 +346,7 @@ public void ExtendCurrentSubscription(DateTime newEndDate)
 			MemberSubscription s = MemberSubscriptions[i];
 			if (s.Dates.Contains(DateTime.Today))
 			{
-				s.Dates = new DateTimeRange(s.Dates.StartDate, newEndDate);
+				s.Dates.UpdateEnd(newEndDate);
 				RegisterDomainEvent(new SubscriptionUpdatedEvent(this, s));
 			}
 		}

src/DevBetterWeb.Core/Services/MemberSubscriptionRenewalService.cs

@@ -30,6 +30,7 @@ public async Task ExtendMemberSubscription(string email, System.DateTime subscri
     if (member is null) throw new MemberWithEmailNotFoundException(email);
     member.ExtendCurrentSubscription(subscriptionEndDate);
 
+    await _memberRepository.UpdateAsync(member);
 		await _memberRepository.SaveChangesAsync();
 
 		_logger.LogInformation($"Extended {member.UserFullName} subscription to {subscriptionEndDate.ToShortDateString}");

src/DevBetterWeb.Core/ValueObjects/DateTimeRange.cs

@@ -17,13 +17,18 @@ public DateTimeRange(DateTime startDate, DateTime? endDate)
     EndDate = endDate;
   }
 
-  /// <summary>
-  /// Returns total number of days in the DateTimeRange.
-  /// If no EndDate has been specified, will use provided endDateToUseIfMissing instead.
-  /// </summary>
-  /// <param name="endDateToUseIfMissing"></param>
-  /// <returns></returns>
-  public int ToDays(DateTime endDateToUseIfMissing)
+  public void UpdateEnd(DateTime endDate)
+  {
+	  EndDate = endDate;
+  }
+
+	/// <summary>
+	/// Returns total number of days in the DateTimeRange.
+	/// If no EndDate has been specified, will use provided endDateToUseIfMissing instead.
+	/// </summary>
+	/// <param name="endDateToUseIfMissing"></param>
+	/// <returns></returns>
+	public int ToDays(DateTime endDateToUseIfMissing)
   {
     var end = EndDate ?? endDateToUseIfMissing;
 
@@ -48,14 +53,13 @@ public int ToDaysInRangeThroughPeriodEndDate(DateTime periodEndDate)
 
   public bool Contains(DateTime date)
   {
-    if (date >= StartDate && date <= EndDate)
-    {
-      return true;
-    }
-    return false;
+	  if (date < StartDate) return false;
+	  if (EndDate == null) return true;
+
+	  return date <= EndDate;
   }
 
-  protected override IEnumerable<IComparable> GetEqualityComponents()
+	protected override IEnumerable<IComparable> GetEqualityComponents()
   {
     yield return StartDate;
     yield return EndDate ?? DateTime.MaxValue;

src/DevBetterWeb.Infrastructure/Data/Config/MemberSubscriptionConfig.cs

@@ -8,7 +8,7 @@ class MemberSubscriptionConfig : IEntityTypeConfiguration<MemberSubscription>
 {
   public void Configure(EntityTypeBuilder<MemberSubscription> builder)
   {
-    builder.OwnsOne(x => x.Dates)
-           .ToTable("MemberSubscriptionDates");
-  }
+    builder
+	    .ComplexProperty(x => x.Dates);
+	}
 }