fix: respect explicit LIMIT in Cypher query_graph#40
Open
re-thc wants to merge 1 commit intoDeusData:mainfrom
Open
fix: respect explicit LIMIT in Cypher query_graph#40re-thc wants to merge 1 commit intoDeusData:mainfrom
re-thc wants to merge 1 commit intoDeusData:mainfrom
Conversation
applyLimit() silently capped all results to maxResultRows (200), even when the user specified a higher LIMIT clause. This caused aggregation queries like COUNT() to silently undercount when the dataset exceeded 200 rows. Now explicit LIMIT values are respected as-is. The 200-row default still applies when no LIMIT clause is provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applyLimit() silently caps all query results to maxResultRows (200), even when the
user provides a higher explicit LIMIT clause.
A query like MATCH (f:Function) RETURN
f.name LIMIT 500 still returns at most 200 rows with no warning. This also causes
COUNT() aggregations to undercount when the pre-aggregation result set exceeds 200
rows.