fix(discover): skip .worktrees directory during indexing#37
Open
wassertim wants to merge 1 commit intoDeusData:mainfrom
Open
fix(discover): skip .worktrees directory during indexing#37wassertim wants to merge 1 commit intoDeusData:mainfrom
wassertim wants to merge 1 commit intoDeusData:mainfrom
Conversation
Git worktrees (stored in .worktrees/) duplicate the entire source tree, causing the knowledge graph to contain duplicate nodes and edges for every function, class, and route. This is especially problematic in monorepos where worktrees are used for parallel development. Add .worktrees to IGNORE_PATTERNS alongside other VCS/tool directories like .git and .svn. Includes a test case verifying the directory and its contents are skipped during discovery. Fixes DeusData#31 (partial — .worktrees specifically)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.worktreestoIGNORE_PATTERNSininternal/discover/discover.go.worktrees/contents are skipped during discoveryProblem
Git worktrees (stored in
.worktrees/) duplicate the entire source tree. When indexing a monorepo that uses worktrees for parallel development, the knowledge graph ends up with duplicate nodes and edges for every function, class, and route. This causes:search_graphresults pointing to worktree copies instead of the main sourceContext
Discovered while evaluating codebase-memory-mcp on a TypeScript monorepo with active worktrees. Related to #31 (
.gitignoresupport would also solve this, but.worktreesshould be unconditionally skipped like.git).Test plan
go test ./internal/discover/ -v -run TestDiscoverSkipsWorktreespassesTestDiscoverBasicstill passes