-
Notifications
You must be signed in to change notification settings - Fork 5
Manually construct flake archive, update tar #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cole-h
wants to merge
1
commit into
main
Choose a base branch
from
manually-construct-archive
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
tar crate 0.4.46 HeaderMode Deterministic Complete set_metadata_in_mode preserves mode bits 0o755 0o644💡 Result:
In the
tarcrate (version 0.4.46), theHeaderMode::Deterministicvariant is designed to produce reproducible archive headers by excluding metadata that changes between builds, such as specific ownership (UID/GID) and timestamps [1][2]. Whenset_metadata_in_modeis called withHeaderMode::Deterministic, the crate handles file mode bits explicitly to maintain a standard, deterministic state [2]: 1. Ownership: UID and GID are set to 0 [2]. 2. Timestamp: The mtime is set to a constantDETERMINISTIC_TIMESTAMPto avoid issues with zero-value timestamps in some tools [3][2]. 3. Mode Bits: The crate does not simply copy the raw mode bits from the source filesystem [2]. Instead, it applies logic to normalize them [2]: - It checks if the file is a directory or if the user-execute bit (0o100) is set on the original file [2]. - If either condition is true, it sets the mode to 0o755 [2]. - Otherwise, it sets the mode to 0o644 [2]. This mechanism ensures that the resulting tar headers have predictable, consistent permissions (0o755 or 0o644) regardless of the specific umask or file permissions present on the system where the archive is being created [2]. In contrast,HeaderMode::Completepreserves the original metadata, including full ownership and mode bits, from the filesystem [2].Citations:
Preserve original permission bits in tar headers
tar::HeaderMode::Deterministicnormalizes archived mode bits (directories/executables ->0o755, others ->0o644) instead of preserving the filesystem/store modes, which can widen permissions versus what you started with. Since Lines 224-226 already overwritemtime/uid/gid, switch toHeaderMode::Completeto preserve themetadata-provided mode bits while keeping those fields controlled.Suggested change
📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah. Honestly, I'd rather it do the equivalent of
chmod ugo-won everything but Nix already does that for us when it extracts the flake to the store so...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cole-h, understood — since Nix enforces read-only store permissions at extraction time regardless of what's in the tarball, the wider0o755/0o644modes fromHeaderMode::Deterministicare harmless in practice. Makes sense to leave it as-is.(ᵔᴥᵔ)
✏️ Learnings added