Restore x86_64-darwin

[lucperkins]

Summary by CodeRabbit

• Chores
  • Updated GitHub Actions workflows to enhance X64 macOS build artifact handling across release processes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

GitHub Actions workflows modified to introduce x86_64 macOS artifact caching across release pipelines (branches, PRs, tags). A comment line added to the build matrix in build.yaml.

Changes

Cohort / File(s)	Summary
Build matrix comment .github/workflows/build.yaml	Inserted comment line in GitHub Actions matrix preceding the aarch64-darwin entry.
X64-macOS artifact caching .github/workflows/release-branches.yaml, .github/workflows/release-prs.yaml, .github/workflows/release-tags.yaml	Added pre-steps to download and cache X64-macOS artifacts from cache-binary-X64-macOS path and persist them to artifacts/X64-macOS directory before existing ARM64-macOS handling. In release-tags.yaml, additionally added renaming step to organize X64-macOS artifacts into final naming scheme.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Repetitive artifact caching pattern across three workflow files with consistent implementation
• Configuration changes only; no complex logic or control-flow modifications
• Single build.yaml change is cosmetic (comment insertion)
• Primary focus: understanding artifact path mappings and cross-architecture caching strategy

Possibly related PRs

• Auto-update README when supported branches list changes #199: Related CI/workflow changes for x86_64-darwin macOS handling in GitHub Actions

Suggested reviewers

• cole-h

Poem

🐰 A comment hops in the build matrix bright,
While X64 artifacts cache through the night,
From macOS paths, we copy with care,
Hopping through workflows, caching everywhere!
The rabbit approves of this workflow delight! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Restore x86_64-darwin' directly describes the main objective of the pull request, which adds support for x86_64 macOS (x86_64-darwin) builds across multiple GitHub Actions workflows.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch x86-macos-package

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc07be0 and c0c3098.

📒 Files selected for processing (4)

• .github/workflows/build.yaml (1 hunks)
• .github/workflows/release-branches.yaml (1 hunks)
• .github/workflows/release-prs.yaml (1 hunks)
• .github/workflows/release-tags.yaml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: Check flake.lock test (clean 👼)
• GitHub Check: Check flake.lock test (dirty 😈)
• GitHub Check: Check flake.lock test (CEL condition)
• GitHub Check: Test Rust
• GitHub Check: Nix and Rust checks

🔇 Additional comments (3)

.github/workflows/build.yaml (1)

18-18: Clarify how aarch64-darwin runner supports x86_64-darwin builds.

The comment documents that the aarch64-darwin entry serves dual purposes, but doesn't explain the mechanism—whether x86_64-darwin binaries are cross-compiled on ARM64 runners, sourced from elsewhere, or handled via release workflows. Per the PR summary, x86_64-darwin support is added to release workflows, but the strategy here is unclear.

Please clarify:

1. Does this build.yaml matrix actually generate x86_64-darwin artifacts, or is that purely in the release workflows?
2. If the aarch64-darwin runner is used for x86_64-darwin builds (e.g., via cross-compilation), that should be visible in the build steps or more explicitly documented.
3. Verify that the release workflows (release-branches.yaml, release-prs.yaml, release-tags.yaml) properly handle x86_64-darwin artifact caching as intended.

If x86_64-darwin builds are managed entirely by release workflows, consider clarifying this comment to avoid confusion:

-          # we also use this for x86_64-darwin
+          # Build artifacts for ARM64 macOS; x86_64-darwin handled in release workflows

.github/workflows/release-tags.yaml (1)

64-69: Rename logic is sound.

The rename pattern is consistent and correctly handles the X64-macOS artifact naming. Assuming the upstream artifact sourcing is correct, this step is good.

.github/workflows/release-prs.yaml (1)

38-44: Review comment is incorrect—the ARM64 artifact reuse for x86_64-darwin is intentional and properly documented.

Verification of build.yaml shows:

1. No x86_64-darwin build exists: The build matrix contains only three entries: aarch64-darwin (ARM64-macOS), aarch64-linux (ARM64-Linux), and x86_64-linux (X64-Linux).

2. Intentional reuse is documented: Line 18 of build.yaml explicitly comments "we also use this for x86_64-darwin" on the aarch64-darwin entry, and line 38 of release-prs.yaml repeats this: "x86_64-darwin (uses the aarch64-darwin build)".

3. This is the only macOS binary produced: Since no separate x86_64-darwin build is configured, the ARM64-macOS artifact is the sole macOS binary available—the Rosetta 2 compatibility approach you mentioned in your own review.

The code is correct and working as designed. No changes are needed.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}