Skip to content

Use determinate-specific input names#157

Open
heywoodlh wants to merge 1 commit intoDeterminateSystems:mainfrom
heywoodlh:fix-input-conflict
Open

Use determinate-specific input names#157
heywoodlh wants to merge 1 commit intoDeterminateSystems:mainfrom
heywoodlh:fix-input-conflict

Conversation

@heywoodlh
Copy link

@heywoodlh heywoodlh commented Jan 29, 2026

I watch my flake.lock pretty closely and don't like duplicate inputs. This renames generic inputs to something specific to Determinate -- since Determinate doesn't want users overriding nixpkgs.

Here's a snippet from my flake.nix which removes duplicate inputs:

    # TODO: update to upstream input when PR is merged
    determinate-nixpkgs.url = "https://api.flakehub.com/f/pinned/NixOS/nixpkgs/0.2505.811874%2Brev-daf6dc47aa4b44791372d6139ab7b25269184d55/019a3494-3498-707e-9086-1fb81badc7fe/source.tar.gz"; 

    determinate-nix = {
      url = "github:heywoodlh/nix-src/fix-input-conflict";
      inputs.determinate-nixpkgs.follows = "determinate-nixpkgs";
      inputs.flake-parts.follows = "flake-parts";
      inputs.git-hooks-nix.follows = "pre-commit-hooks";
    };
    determinate = {
      url = "github:heywoodlh/determinate/fix-input-conflict";
      inputs.determinate-nixpkgs.follows = "determinate-nixpkgs";
      inputs.determinate-nix.follows = "determinate-nix";
    };

Should probably not be merged until the same PR is approved and merged in nix-src.

Summary by CodeRabbit

  • Documentation

    • Removed outdated guidance regarding follows directives.
  • Chores

    • Updated core project dependencies for improved build consistency and reproducibility.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

This PR replaces the flake's top-level Nix and Nixpkgs inputs with Determinate-managed versions (determinate-nix and determinate-nixpkgs), updates the outputs function signature accordingly, and rewires all internal references to use the new inputs. Documentation is updated to reflect the new pattern.

Changes

Cohort / File(s) Summary
Documentation
README.md
Removed advisory sentence against using follows directive for Nixpkgs with Determinate flake.
Flake Configuration
flake.nix
Replaced nix and nixpkgs inputs with determinate-nix and determinate-nixpkgs; updated outputs function signature and all internal references (nixpkgs.lib.genAttrsdeterminate-nixpkgs.lib.genAttrs, import source changes).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • colemickels

Poem

🐰 A determined path, so clear and bright,
Inputs rewired with Determinate might,
No more nixpkgs, determinate's the way,
Flakes flow smoother, hooray, hooray!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: renaming generic flake inputs to determinate-specific names, which is exactly what the changeset accomplishes across flake.nix and documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant