Skip to content

Add support for Set Bonus mod socket on event items#11753

Open
FlaminSarge wants to merge 7 commits into
masterfrom
set-bonus-mod
Open

Add support for Set Bonus mod socket on event items#11753
FlaminSarge wants to merge 7 commits into
masterfrom
set-bonus-mod

Conversation

@FlaminSarge
Copy link
Copy Markdown
Contributor

@FlaminSarge FlaminSarge commented May 7, 2026

The Inventory page's Set Bonus indicator now reflects any active set bonus mods on event items, if they help fulfill a set bonus requirement.
fotlWildcard handling is removed in favor of checking whether the mod socket is present and visible.
The Set Bonus picker in LO will properly consider the mod socket as a wildcard when determining which set bonuses can be shown/picked.
When using syncFromEquipped, the currently equipped mod is considered as a part of the active set bonuses on the character.

Changelog: Add support for the Set Bonus mod socket on event items, including modslot:setbonus search filter

@FlaminSarge
Copy link
Copy Markdown
Contributor Author

FlaminSarge commented May 7, 2026

I plan to eventually set this up so that LoadoutOptimizer looks specifically at what plugs are available and can be selected on the item, but for first pass setting up the rest of the handling.
It might also be sufficient to see if the socket is visible and set the wildcard bool that way. Did the latter.

Only shows the set bonus as active if the mod itself is enabled
Switches from fotlWildcard in loadout optimizer to seeing if mod socket is visible
Handles mod socket presence when showing set bonus picker
Handles mod socket plug when using syncFromEquipped
@FlaminSarge FlaminSarge marked this pull request as ready for review May 8, 2026 04:40
@bhollis
Copy link
Copy Markdown
Contributor

bhollis commented May 8, 2026

Screenshots? I'm not sure I understand

@FlaminSarge
Copy link
Copy Markdown
Contributor Author

FlaminSarge commented May 8, 2026

Screenshots? I'm not sure I understand

Not sure if screenshots will help explain what this does.

If/when the mod socket on FOTL masks/Guardian Games class items is enabled, the main inventory UI for Set Bonus display will show the actual equipped set bonus if those items fulfill set bonus requirements (e.g. my Hunter has one Last Discipline item on + GG cloak with Last Discipline mod slotted and not-disabled -> Last Discipline perk appears in the usual Set Bonus indicator location.)

In addition, the presence and visibility of the mod socket on an item will allow that item to count towards the set bonus wildcard system that @chainrez set up for FOTL masks before, removing the hardcoded FOTL mask hashes. I've doublechecked that the active mod doesn't double-count alongside the wildcard in LO, either.
As an update to the wildcard system, the Set Bonus picker in LO will also handle the mod socket's availability as a wildcard if it is able to push a given set bonus past one of its perk thresholds (still hides the set bonus if the user's armor can't fulfill any perks in the set even with the wildcard).

Hopefully this is more readable
# Conflicts:
#	src/app/loadout-builder/item-filter.ts
#	src/app/loadout-builder/process-worker/process.ts
#	src/app/loadout-builder/process/mappers.ts
@bhollis
Copy link
Copy Markdown
Contributor

bhollis commented May 11, 2026

I'm gathering there's now some mod that confers set bonuses?

@FlaminSarge
Copy link
Copy Markdown
Contributor Author

I'm gathering there's now some mod that confers set bonuses?

Yeah, it was originally added in Halloween 2025 but we kind of papered over it with fotlWildcard, but Guardian Games 2026 added it on another item and I'm about a month late on implementing it properly (since the end of GG). My guess is some parts of this impl will have to change regarding the enabled/visibleInGame checks next time an event rolls around, but future-proofing it as best as I can right now.

Comment thread src/app/loadout-builder/process/mappers.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants