Skip to content

Conversation

@wizlee
Copy link

@wizlee wizlee commented Aug 21, 2021

Summary

  • update dev dependencies due to incompatibility with Create React App
  • Add Unstoppable Domain resolution API

Screenshots for success scenarios

  • Successfully receive

success-receive

  • successfully send confirmation dialog

success-send-confirmation

  • successfully sent

success-send

Screenshots for error scenarios

  • Valid domain but no associated dash address

error-no-address

  • Valid domain with dash address, insufficient balance

error-domain-with-dash-addr-no-balance-to-send

@wizlee
Copy link
Author

wizlee commented Aug 21, 2021

Related to #8 . Find out that able to create a PR from fork.

@JohnnyJumper
Copy link

It should be possible to get the needed information from the domain by using resolution#addr only. In case if the domain is not registered, a record is not found, or this domain is not supported (not a domain) the library will throw a corresponding error. You can catch that one and proceed with the rest of the logic. This change can speed up the process as it requires only 1 network call instead of 2.

Also, it is a great UX when the resolved address is shown under the domain once it is resolved.

Other than those 2 points above the PR looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants