fix(readme): correct Maven groupId and version to match published artifact#69
Open
tdillenbeck wants to merge 2 commits into
Open
fix(readme): correct Maven groupId and version to match published artifact#69tdillenbeck wants to merge 2 commits into
tdillenbeck wants to merge 2 commits into
Conversation
…ifact The artifact on Maven Central is published under com.thycotic.secrets (the legacy company name), not com.delinea.secrets. No artifact has been published under the delinea groupId. Also bumps version from 1.0 to 1.0.1 which is the actual latest release on Maven Central. Fixes #68 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Tests run without a live DSV tenant using MockRestServiceServer. Covers getSecret() path normalization (leading-slash stripping), response deserialization, TLD normalization, and base-URL trailing- slash removal in the factory bean. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.delinea.secrets→com.thycotic.secretsin the Maven dependency snippet1.0→1.0.1(the actual latest release on Maven Central)Context
No artifact has ever been published to Maven Central under
com.delinea.secrets. The only published artifact iscom.thycotic.secrets:dsv-sdk-javawith versions1.0and1.0.1. The README was updated with the new company name when Thycotic became Delinea, but the Maven artifact was not republished under the new groupId, making the README's dependency snippet non-functional.Fixes #68
🤖 Generated with Claude Code