Fixes, expands, and modifies E2E tests#14329
Open
devGregA wants to merge 9 commits intoDefectDojo:devfrom
Open
Fixes, expands, and modifies E2E tests#14329devGregA wants to merge 9 commits intoDefectDojo:devfrom
devGregA wants to merge 9 commits intoDefectDojo:devfrom
Conversation
…button Both product_metadata_test.py and endpoint_extended_test.py were using id_name/id_value as form field IDs, but DefectDojo metadata forms use Django formsets which prefix fields as id_form-0-name/id_form-0-value. Also fixed submit button selector from input.btn.btn-primary to button.btn.btn-success matching the actual template. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The product page dropdown uses "Add Custom Fields" link text (not
"Add Metadata" like the endpoint page), causing NoSuchElementException.
Navigate directly to product/{pid}/add_meta_data and edit_meta_data
URLs instead, which works across both V3 and non-V3 modes.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the E2E Test Expansion Project
Previous State
The DefectDojo integration test suite had 26 test suites covering core functionality: Finding, Report Builder, Notes, Regulation, Product Type, Product, Endpoint, Engagement, Environment, Test, User, Group, Product Group, Product Type Group, Product Member, Product Type Member, IBM AppScan, Search, File Upload, Dedupe, Announcement Banner, Close Old Findings (2 variants), False Positive History, Various Pages, and Notifications.
Many DefectDojo features had zero E2E test coverage: system settings, credentials, tool management, SLA configuration, dashboards, login flows, calendars, finding groups, questionnaires, benchmarks, webhooks, threat models, metrics pages, user profiles, engagement checklists, action history, reimport scanning, and more.
There was also one pre-existing broken test —
tool_config.py— which looked for an HTML element (link_tc_edgescan_scan) that doesn't exist in the current UI.What I Changed
34 new test files created: