fix unsoundness of eval_names#11
Merged
Merged
Conversation
matthiasvedder
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR against the changes in #10 to make
eval_namescloser to how we deal with strings indeepsign-wininput, just without the unsafe code (consequently this zero-initializes the buffers). It's superior to the existing version ofeval_namesin that it doesn't truncate long names, and doesn't crash the tests with access violationsEdit: there is definetly some unsoundness somewhere else, but the eval_names test seems to work wit these changes. The get_eval test still doesn't.