Dla finder pipeline#40
Open
samwang141224 wants to merge 14 commits into
Open
Conversation
profxj
requested changes
Nov 20, 2020
Collaborator
profxj
left a comment
profxj
left a comment
There was a problem hiding this comment.
I started reviewing but we need to discuss this new DLA_finder folder
and why it is outside of dla_cnn.
| @@ -0,0 +1,20 @@ | |||
| import time | |||
Collaborator
There was a problem hiding this comment.
Add a brief descrption of this module.
|
|
||
|
|
||
| class Timer: | ||
| def __init__(self, disp=None): |
Collaborator
There was a problem hiding this comment.
Add doc strings to each method.
| class Marker(object): | ||
| IGNORE_FEATURE = -10 | ||
|
|
||
| def __init__(self, lam_rest_location, marker_type=IGNORE_FEATURE): |
| @@ -0,0 +1,29 @@ | |||
| """ Parent class for a set of Data, training or real""" | |||
Collaborator
There was a problem hiding this comment.
Why do we have a completely new folder named DLA_finder located
outside of dla_cnn ?
| @@ -0,0 +1,8 @@ | |||
| """ Simple object to hold DLAs""" | |||
Collaborator
There was a problem hiding this comment.
Isn't this code identical to that inside dla_cnn/data_model ?
I don't understand what we are doing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear X, we have sorted out our codes and uploaded them to the DLA_finder folder, there is a notebook DLA_finder/desi/nb/Pipeline for DESI_DLA_finder.ipynb describing the process to use these codes.