Generate training set#39
Conversation
|
I update write_as_tf_file module to TF 2.1 and write a module for reading TFRecord file. |
profxj
left a comment
There was a problem hiding this comment.
Just a few requests. Sorry this took so long
| @@ -0,0 +1,80 @@ | |||
| import tensorflow as tf | |||
There was a problem hiding this comment.
Add a line at the top explaining the purpose of this module.
| Split bins for snr_array,zdla_array,nhi_array | ||
| ------------------------------------------------------------------------------------- | ||
| parameters; | ||
| data_array:np.ndarray |
There was a problem hiding this comment.
add short descriptions for each
| Uniform snr in snrrange | ||
| Parameter | ||
| --------- | ||
| snr:np.ndarray |
There was a problem hiding this comment.
add short descriptions for each
|
|
||
| def snr_uniform(snr,ixs,binnum,num,snrrange): | ||
| """ | ||
| Uniform snr in snrrange |
There was a problem hiding this comment.
explain what this method does
|
|
||
| def uniform_z_nhi(idarray,z_bins,nhi_bins,num,Mocks): | ||
| """ | ||
| Uniform zdla,nhi,get sightline id |
There was a problem hiding this comment.
explain what this method does
| ------------------------------------------------------------------------------- | ||
| parameters; | ||
| idlist:numpy.ndarray | ||
| sightlineid array after uniform snr |
Hey X,
I open a new PR in order to make the changes more clear.