feat: merge rust-core into main — v0.5.0 polyglot monorepo

[DecisionNerd]

Summary

• Merges all 14 commits from rust-core into main, bringing the Rust workspace, BDD infrastructure, and all M8 milestone work into the default branch
• After this merge, rust-core will be deleted; all future feature work branches off main and targets main
• The codebase will be WIP (mixed Python 0.4.x + Rust 0.5.0 scaffolding) until the v0.5.0 release — this is intentional

What's included

• Rust workspace (crates/) with gf-ast, gf-cypher, gf-exec, gf-ir, gf-rel, gf-storage, gf-core, gf-bindings-py, gf-bindings-node
• Three-runner BDD CI pipeline (bdd.yml): Python pytest-bdd, Node cucumber-js, Rust cargo test
• 222 TCK feature files tagged @tck @skip-node @skip-rust
• BDD step definitions skeleton for all three runners
• Python v0.5.0 stub (api_v05.py) with typed Arrow returns
• 176 unit tests for api_v05.py
• pnpm workspace for Node tooling
• Updated bdd.yml + test.yml to trigger on main

Test plan

• Conflicts resolved in all 10+ conflicted files (take rust-core version for Rust files, merged for shared files)
• CI passes on merge commit
• Delete rust-core branch after merge

Closes #627

🤖 Generated with Claude Code

Note

Merge rust-core into main as v0.5.0 polyglot monorepo

• Adds a new bdd.yml CI workflow that runs Python, Node, and Rust BDD test suites on pushes and PRs to main, uploading artifacts for results and logs.
• Relaxes GraphForge.__init__ (Python) and GraphForge::new (Rust) to accept any existing path, not just directories; raises StorageError only when the path does not exist.
• Relaxes GraphForge.find to accept an empty-string query as valid when no vector is provided; previously this raised a validation error.
• Removes the rust-core branch from CI push triggers in test.yml.
• Behavioral Change: GraphForge(path) now succeeds for file paths; callers that relied on a directory check will no longer see that error.

^{Macroscope summarized ad83e76.}

Summary by CodeRabbit

• Changes

  • Modified path validation to only check path existence; removed directory-type requirements.
  • Updated query validation to accept empty query strings when vector input is provided.

• Infrastructure

  • Enhanced test infrastructure with improved step definitions and configuration updates.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d17dcd9b-f6c6-4ed9-8e71-c1a198bda507

📥 Commits

Reviewing files that changed from the base of the PR and between a4d9bf7 and ad83e76.

⛔ Files ignored due to path filters (3)

• .github/workflows/bdd.yml is excluded by !**/.github/**
• .github/workflows/test.yml is excluded by !**/.github/**
• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (12)

• .cargo/config.toml
• crates/gf-ast/src/lib.rs
• crates/gf-core/src/lib.rs
• crates/gf-core/tests/bdd/api_steps.rs
• crates/gf-core/tests/bdd/main.rs
• crates/gf-exec/src/lib.rs
• src/graphforge/api_v05.py
• tests/features/conftest.py
• tests/features/node/cucumber.js
• tests/features/node/package.json
• tests/features/steps/api_steps.py
• tests/features/test_api_bdd.py

---

Walkthrough

This PR refines core validation logic (GraphForge path checks, find() query constraints, add_edges node resolution), removes Serde from AstQuery, refactors RecordBatch constructors, and standardizes Rust and Python BDD test framework infrastructure including step definition formatting and _Ctx initialization. Node test configuration is simplified to use relative globs.

Changes

Core API and validation refinements

Layer / File(s)	Summary
Serde removal from AstQuery crates/gf-ast/src/lib.rs	Public AstQuery type no longer derives serde::Serialize and serde::Deserialize, retaining only Debug and Clone.
Storage validation and constructor refactoring crates/gf-core/src/lib.rs, crates/gf-exec/src/lib.rs	GraphForge::new removes directory-existence check, now only validating path exists. RecordBatch::empty refactored to single-expression column constructors in both gf-core and gf-exec.
Python API refinements src/graphforge/api_v05.py	find() validation relaxed: only errors when both query and vector are None; empty query no longer fails if vector is set. add_edges removes isinstance(..., int) guard, accepting any integer-like hashable node identifiers. Schema constants and empty-table constructors reorganized with updated formatting.

BDD test infrastructure and step definitions

Layer / File(s)	Summary
Rust cucumber-rs step definitions crates/gf-core/tests/bdd/api_steps.rs, crates/gf-core/tests/bdd/main.rs	Step decorators and function signatures reformatted into multi-line forms. "Nonexistent path" GIVEN step now records "path does not exist" error. Module docs updated to clarify TCK scenarios are tagged @skip-rust and skipped during Rust test runs.
Python pytest-bdd step definitions and state tests/features/steps/api_steps.py	Step decorators normalized with consistent parsers.parse() formatting. _Ctx class attributes (nodes, edges, extra) initialized with default mutable values. Step handlers extended for vector search edge cases (no args, empty, NaN, infinity), bulk add operations, method dispatch, and index/rank/find scenarios, all maintaining xfail-on-stub behavior.
Test configuration and tooling tests/features/conftest.py, tests/features/node/cucumber.js, tests/features/node/package.json, tests/features/test_api_bdd.py	Node Cucumber config switches to relative feature globs (features/**/*.feature) and relative step-definition paths, removing absolute path construction and tag filters. Python conftest adds tempfile and Path imports. Node package.json reorders typescript/ts-node together. Test module adds pytest import.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• DecisionNerd/graphforge#624: PR modifies Rust workspace skeleton elements directly referenced in this issue, including gf-ast public types, gf-core validation and BDD step tests.

Possibly related PRs

• DecisionNerd/graphforge#631: Both PRs update Node BDD runner configuration in tests/features/node/cucumber.js, including feature discovery paths and tag filtering behavior.

Suggested labels

enhancement

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch rust-core

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
9270	2	9268	17

View the full list of 2 ❄️ flaky test(s)

tests.unit.api.test_api_v05.TestFind::test_whitespace_only_query_without_vector_raises

Flake rate in main: 100.00% (Passed 0 times, Failed 5 times)

Stack Traces | 0.001s run time

.../unit/api/test_api_v05.py:1155: in test_whitespace_only_query_without_vector_raises
    with pytest.raises(ValidationError, match="at least one of"):
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E   Failed: DID NOT RAISE <class 'graphforge.exceptions.ValidationError'>

tests.unit.api.test_api_v05.TestGraphForgeInit::test_file_path_raises_storage_error

Flake rate in main: 100.00% (Passed 0 times, Failed 5 times)

Stack Traces | 0.006s run time

.../unit/api/test_api_v05.py:347: in test_file_path_raises_storage_error
    with pytest.raises(StorageError, match="must be a directory"):
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E   Failed: DID NOT RAISE <class 'graphforge.exceptions.StorageError'>

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}