Various Changes and Improvements, Additional Flags#23
Various Changes and Improvements, Additional Flags#23notquitenothing wants to merge 3 commits intoDavidAnson:mainfrom
Conversation
Added intereactive mode that when active, opens dialog boxes to select input files and output folder if they are not provided. Added flag to also copy unconverted image files, such as those that are already in jpeg format, to output folder. When a file fails to convert, add it to a list that is printed at the end of execution instead of exiting immediately. Conversion output now includes full output file path since it can be selected.
notquitenothing
changed the title
|
Thank you for the submission! These look like some interesting changes and you seem to have been very thorough about the process. The challenge on my side is I haven’t used this script (or PowerShell) for a few years and confidence in my ability to review effectively is low. My head is not in the right place to accept this PR now, but I will leave it open for consideration. For your own future reference, maintainers will generally be more receptive to multiple standalone changes vs. a single one that adds unrelated features. Thank you again for sharing this! If you decide to fork the project out of impatience, I will understand. :) |
|
Totally understand, feel free to leave it open, close it, or copy only what you want whenever you get around to it. My changes were to make it easier for a family member to use the script, using a shortcut to populate some of the flags, and thought someone else might get some use out of it. Thanks for your work 😊 |
2 participants
Various changes and improvements. Changes should all be backwards compatible and behind flags, should be almost no change in behavior unless the new flags are used. Open to feedback, feel free to merge as is, cherry-pick, or reject. Changes include:
-OutputFolderPath,-o) to select an output folder separate from the input file.-OutputUnconverted,-u) which will copy image files already in the converted format, jpeg, to the output folder if it is specified.-InteractiveMode,-t) which will open dialog file pickers for input files and output folder if they are not specified in a parameter.-NoFailOnConvert). Files that failed to convert are printed in a message at the end of the script.