Fix replacement so that it works when a newline falls between 'the' and 'cloud'#3
Open
jeffgdotorg wants to merge 1 commit intoDaveRandom:masterfrom
Open
Fix replacement so that it works when a newline falls between 'the' and 'cloud'#3jeffgdotorg wants to merge 1 commit intoDaveRandom:masterfrom
jeffgdotorg wants to merge 1 commit intoDaveRandom:masterfrom
Conversation
zaverucha
approved these changes
Feb 11, 2017
zaverucha
left a comment
zaverucha
left a comment
There was a problem hiding this comment.
Looks good to me. I hit this issue as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading the following page:
http://www.debian.org/News/2012/20120425
I noticed that the extension was failing to do its job. Turns out there's a newline in the HTML source between the tokens "the" and "cloud".
So I fixed the regex replace so that it handles this situation.
You're welcome.
-jeff