fix: handle \\ escape sequence in minify_string()#1003
Open
SummerSolsticeMuch wants to merge 1 commit intoDaveGamble:masterfrom
Open
fix: handle \\ escape sequence in minify_string()#1003SummerSolsticeMuch wants to merge 1 commit intoDaveGamble:masterfrom
SummerSolsticeMuch wants to merge 1 commit intoDaveGamble:masterfrom
Conversation
minify_string() only handled \" as an in-string escape but not \\. The sequence \\" (escaped backslash followed by closing quote) was misinterpreted as an escaped quote, causing the minifier to read past the actual string boundary and include trailing data in the output. Add \\ handling before the \" check so that escaped backslashes are consumed correctly and the real closing quote is recognized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\\(escaped backslash) handling inminify_string()before the\"checkminify_string()only handled\"as an in-string escape but not\\. The sequence\\"(escaped backslash followed by closing quote) was misinterpreted as an escaped quote, causing the minifier to read past the actual string boundary and include trailing data in the output.Test plan
cJSON_Minify()on{"key": "value\\"} trailingshould produce{"key":"value\\"}withouttrailing\"still minify correctly