fix: add overflow check in decode_array_index_from_pointer()#1002
Open
SummerSolsticeMuch wants to merge 1 commit intoDaveGamble:masterfrom
Open
fix: add overflow check in decode_array_index_from_pointer()#1002SummerSolsticeMuch wants to merge 1 commit intoDaveGamble:masterfrom
SummerSolsticeMuch wants to merge 1 commit intoDaveGamble:masterfrom
Conversation
The function parses a decimal string into size_t with no overflow detection. A very large numeric string (e.g. "18446744073709551617") silently wraps around, potentially resolving to an unintended small array index. Add an overflow guard before the multiply-and-add so that indices exceeding SIZE_MAX are rejected instead of wrapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decode_array_index_from_pointer()The function parses a decimal string into
size_tviaparsed_index = (10 * parsed_index) + digitwith no overflow check. A crafted large numeric string (e.g."18446744073709551617") silently wraps aroundsize_t, potentially resolving to an unintended small array index in JSON Patch operations.Test plan
/arr/18446744073709551617— should fail instead of wrapping to a small index