fix: correct ~1 decode in decode_pointer_inplace()#1001
Open
SummerSolsticeMuch wants to merge 1 commit intoDaveGamble:masterfrom
Open
fix: correct ~1 decode in decode_pointer_inplace()#1001SummerSolsticeMuch wants to merge 1 commit intoDaveGamble:masterfrom
SummerSolsticeMuch wants to merge 1 commit intoDaveGamble:masterfrom
Conversation
The ~1 escape sequence (RFC 6901 Section 4) should decode to '/'. The ~0 case correctly writes to decoded_string[0], but the ~1 case writes to decoded_string[1] instead of decoded_string[0]. This is a copy-paste bug from the ~0 case where only the character was changed but the index was also accidentally changed. This causes all JSON Pointer and JSON Patch operations on keys containing '/' to silently fail or target the wrong key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decode_pointer_inplace()where~1writes todecoded_string[1]instead ofdecoded_string[0]The
~0case correctly writes todecoded_string[0], but the~1case writes todecoded_string[1]— a copy-paste bug. This causes all JSON Pointer / JSON Patch operations on keys containing/(encoded as~1per RFC 6901) to silently fail or target the wrong key.Test plan
/a~1bto an object with keya/b— should succeed (currently returns error 13)~0decoding still works correctly