Rewrite Niedersachsen spider with shapefile-first approach #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tifa365
force-pushed
the
feature/niedersachsen-geodata
branch
from
fe9257f to
ce9fd7f
Compare
Replaces API-only scraping with LSN geodata integration providing 100% geolocation coverage (4,250 schools). Implements robust matching, normalization, and async downloads. Key improvements: - Add shapefile integration for 4 LSN categories (ABS, Förder, BBS, SdG) - Implement Unicode-aware (NFKD) German character normalization - Add collision-safe API indexing with form-aware disambiguation - Use async Scrapy Requests for shapefile downloads (non-blocking) - Generate stable synthetic IDs (SHA-1) for shapefile-only schools - Add path traversal protection in ZIP extraction - Ensure API-only schools are fetched after shapefile processing - Add enhanced school form normalization with long-form variants - Add allowed_domains and stats tracking Coverage: 4,250 schools with geodata (~75% API-enriched, ~25% shapefile-only) Note: API endpoint (schulen.nibis.de) is public but may experience intermittent connectivity. Shapefile processing is fully functional and provides complete geodata coverage.
tifa365
force-pushed
the
feature/niedersachsen-geodata
branch
from
ce9fd7f to
6450645
Compare
Member
|
Sorry but I currently cannot review the PR in this case. None of the links actually return shapefiles and the code seems to overly complicated for what I was hoping for it to be with all of the normalization and encoding handling. Do you think we can somehow find a much simpler version do begin with (even just as a proof of concept)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces API-only scraping with LSN geodata integration providing 100% geolocation coverage (4,250 schools). Implements robust matching, normalization, and async downloads.
Key improvements:
Coverage: 4,250 schools with geodata (~75% API-enriched, ~25% shapefile-only)
Adds pyproj dependency for CRS transformation support.
Note: API endpoint (schulen.nibis.de) is public but may experience intermittent connectivity. Shapefile processing is fully functional and provides complete geodata coverage.