Merged
Conversation
dopenguin
requested review from
oeninghe-dataport and
warm-coolguy
as code owners
|
Member
Author
dopenguin
force-pushed
the
vue3/allow-overflowing-ui-elements
branch
from
02dfaba to
408b9ac
Compare
Simple removing the overflow: hidden would've caused issues with the inset shadow. This change tackles this issue so both the overflowing content and the inset shadow are properly displayed. Resolves: #537
dopenguin
force-pushed
the
vue3/allow-overflowing-ui-elements
branch
from
408b9ac to
8e31292
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simple removing the
overflow: hiddenwould've caused issues with the inset shadow.This change tackles this issue so both the overflowing content and the inset shadow are properly displayed.
Instructions for local reproduction and review
Content in both clients should now may overflow in both snowbox and iceberg.
Relevant tickets, issues, et cetera
Resolves: #537