Merged
Conversation
dopenguin
requested review from
oeninghe-dataport and
warm-coolguy
as code owners
dopenguin
force-pushed
the
vue3/migrate-plugin-attributions
branch
from
d65f87c to
5c9a966
Compare
|
warm-coolguy
requested review from
oeninghe-dataport
and removed request for
oeninghe-dataport
# Conflicts: # examples/snowbox/index.js # src/core/types/main.ts # src/core/types/plugin.ts # vue2/packages/types/custom/core.ts
oeninghe-dataport
requested changes
Mar 5, 2026
Co-authored-by: oeninghe-dataport <oeninghe-dataport@users.noreply.github.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migration of attributions. Should work with
layout: 'nineRegions'in all configuration options forrenderTypeand as currently added in the snowbox as part of the footer.Instructions for local reproduction and review
npm run snowboxand test the visibility of the attributions when toggling layers.layoutto'nineRegions'and test through the three situations forrenderType. Don't forget to move the addition of the plugin to a different position.Relevant tickets, issues, et cetera
Closes #348