Skip to content

Conversation

@velo
Copy link
Collaborator

@velo velo commented Dec 23, 2025

Summary

Adds missing Hadoop dependencies required for Iceberg to work properly:

  • hadoop-common
  • hadoop-mapreduce-client-core

These JARs are now copied to /opt/flink/lib in the Docker image, following the same pattern as hadoop-hdfs-client and aws-msk-iam-auth.

Changes

  • Added hadoop-common and hadoop-mapreduce-client-core as provided dependencies in flink-sql-runner/pom.xml
  • Added maven-dependency-plugin executions to copy both JARs to target directory
  • Updated Dockerfile to COPY both JARs to /opt/flink/lib

Test Plan

  • Verified build compiles with mvn test
  • Verify Iceberg operations work with the new dependencies in a deployed environment

Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds two missing Hadoop dependencies (hadoop-common and hadoop-mapreduce-client-core) required for Iceberg to work properly with Flink. The changes follow the existing pattern used for hadoop-hdfs-client and other provided dependencies.

  • Added two Hadoop dependencies with appropriate exclusions to avoid Jackson and logging conflicts
  • Configured maven-dependency-plugin to copy the JARs during build
  • Updated Dockerfile to include the JARs in /opt/flink/lib

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
flink-sql-runner/pom.xml Added hadoop-common and hadoop-mapreduce-client-core as provided dependencies with Jackson and logging exclusions, plus maven-dependency-plugin executions to copy them to target directory
flink-sql-runner/src/main/docker/Dockerfile Added COPY commands to include hadoop-common and hadoop-mapreduce-client-core JARs in the Flink lib directory

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

velo added 3 commits December 23, 2025 08:50
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
@velo velo merged commit aad5500 into main Dec 23, 2025
5 checks passed
@velo velo deleted the add-hadoop-iceberg-dependencies branch December 23, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants