Skip to content

fix(DRC-2652): Handle missing tables gracefully in row count checks #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix(DRC-2652): Handle missing tables gracefully in row count checks #1104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8c69384
fix(checks): Handle missing tables gracefully in row count checks
seer-by-sentry[bot] Feb 5, 2026
406e364
fix(checks): Return structured status in row count results
iamcxa Feb 5, 2026
71f993e
test(rowcount): Add comprehensive tests for structured status results
iamcxa Feb 5, 2026
0de7b46
test(rowcount): Add more tests for status codes and result differ
iamcxa Feb 5, 2026
3ec4e6f
docs(mcp): add valid selector documentation to row_count_diff tool
iamcxa Feb 5, 2026
9dac745
docs(mcp): add selector documentation to lineage_diff tool
iamcxa Feb 5, 2026
99dfa03
docs(mcp): add selector documentation to schema_diff tool
iamcxa Feb 5, 2026
49e4639
refactor: extract _query_row_count to module-level function
iamcxa Feb 6, 2026
ae82153
fix: improve type safety and fix bug in rowcount module
iamcxa Feb 6, 2026
0811007
fix: address code review feedback for rowcount module
iamcxa Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 37 additions & 5 deletions recce/mcp_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,13 @@ async def list_tools() -> List[Tool]:
"properties": {
"select": {
"type": "string",
"description": "dbt selector syntax to filter models (optional)",
"description": (
"dbt selector syntax to filter models. "
"Valid state selectors: state:new, state:old, state:modified, state:unmodified. "
"Use '+' suffix for downstream: state:modified+ "
"NOTE: 'state:added' is INVALID - use 'state:new'. "
"Example: '1+state:modified+' for modified models with 1 upstream"
),
},
"exclude": {
"type": "string",
Expand Down Expand Up @@ -190,7 +196,11 @@ async def list_tools() -> List[Tool]:
"properties": {
"select": {
"type": "string",
"description": "dbt selector syntax to filter models (optional)",
"description": (
"dbt selector syntax to filter models. "
"Valid state selectors: state:new, state:old, state:modified, state:unmodified. "
"NOTE: 'state:added' is INVALID - use 'state:new'."
),
},
"exclude": {
"type": "string",
Expand All @@ -212,7 +222,19 @@ async def list_tools() -> List[Tool]:
[
Tool(
name="row_count_diff",
description="Compare row counts between base and current environments for specified models.",
description=(
"Compare row counts between base and current environments for specified models. "
"Returns structured results with status information for each model.\n\n"
"Response format: {model_name: {base: {count, status, message?}, curr: {count, status, message?}}}\n\n"
"Status codes:\n"
"- 'ok': Row count retrieved successfully\n"
"- 'not_in_manifest': Model not found in dbt manifest\n"
"- 'unsupported_resource_type': Node is not a model/snapshot\n"
"- 'unsupported_materialization': Materialization doesn't support row counts (e.g., ephemeral)\n"
"- 'table_not_found': IMPORTANT - Table defined in manifest but doesn't exist in database. "
"This indicates stale dbt artifacts or environment misconfiguration. "
"Report this to users as it requires rebuilding dbt artifacts or checking environment setup."
),
inputSchema={
"type": "object",
"properties": {
Expand All @@ -228,11 +250,21 @@ async def list_tools() -> List[Tool]:
},
"select": {
"type": "string",
"description": "dbt selector syntax to filter models (optional)",
"description": (
"dbt selector syntax to filter models. "
"Valid state selectors: state:new, state:old, state:modified, state:unmodified. "
"Sub-selectors: state:modified.body, .configs, .relation, .persisted_descriptions, .macros, .contract. "
"Use '+' suffix for downstream deps: state:modified+ "
"IMPORTANT: 'state:added' is INVALID - use 'state:new' instead. "
"Example: 'state:new,config.materialized:table' or 'state:modified+'"
),
},
"exclude": {
"type": "string",
"description": "dbt selector syntax to exclude models (optional)",
"description": (
"dbt selector syntax to exclude models. "
"Same syntax as select. Example: 'config.materialized:view'"
),
},
},
},
Expand Down
Loading