Adding GeoCoordinates queries to address #100#125
Conversation
|
Hi @iannesbitt. I checked out the branch and ran the tests twice ( Did all tests pass when you ran? Did I miss anything? |
| <property name="converter" ref="solrLongitudeConverter" /> | ||
| </bean> | ||
|
|
||
| <!-- Extract south bounding coordinate from a 'SO:spatialCoverage' property of type 'GeoCoordinates'. --> |
There was a problem hiding this comment.
You added four beans such as schema_org_geoCoordinates_east. But they are not referenced by any place. They should be referenced in the application-context-json-ld.xml file.
| "spatialCoverage": { | ||
| "@type": "Place", | ||
| "geo": [ | ||
| { |
There was a problem hiding this comment.
May we add another part ( or file) having bounding box?
There was a problem hiding this comment.
@taojing2002 This file is meant to test singular coordinate values. There are two test files that implicitly test the bounding box format (example below):
"spatialCoverage": {
"@type": "Place",
"geo": {
"@type": "GeoShape",
"box": "-28.09816 -32.95731 41.000022722222 1.71098"
}
},- https://github.com/DataONEorg/dataone-indexer/blob/bugfix-100-so-spatialcoverage-query-expansion/src/test/resources/org/dataone/cn/index/resources/d1_testdocs/json-ld/bco-dmo/bco-dmo.jsonld
- https://github.com/DataONEorg/dataone-indexer/blob/bugfix-100-so-spatialcoverage-query-expansion/src/test/resources/org/dataone/cn/index/resources/d1_testdocs/json-ld/hakai-deep-schema/hakai-deep-schema.jsonld
If you'd like, I can add an explicit test for the bounding box query, but it should be covered by those two examples.
|
@taojing2002 I never got tests working, so I didn't get to this point. I will review and resubmit. Thank you! |
This PR adds queries that should match the following spatialCoverage definition in a schema.org JSON-LD. It also adds a test file and accompanying systemmetadata.
I once again need help testing this as I don't know how to get it set up myself.