[WIP] Fix legend and metadata deletion issues in signal view#261
Closed
[WIP] Fix legend and metadata deletion issues in signal view#261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Deleting result legend or metadata should be persistent
Problem:
When a result legend is deleted from the signal view, or result metadata is removed from the signal metadata panel, they reappear when de-selecting and re-selecting the signal. This is because the underlying result metadata is not being removed from the object.
Solution Plan:
SIG_ITEM_REMOVEDsignal inBasePlotHandlerFiles to modify:
datalab/gui/plothandler.py- Add signal connection and handler for item removalOriginal prompt
This section details on the original issue you should resolve
<issue_title>Deleting result legend from signal view, or single signal metadata, seems not to work as expected</issue_title>
<issue_description>Description
When a result is shown in signal view, there is a legend.
If you try to delete this legend, it reappears de-selecting and re-selecting the signal.
Additionally, if you delete result-specific metadata, they appears again when de-selecting and re-selecting the signal
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The deletion should be persistent (or not be allowed)
Screenshots
Installation information