Skip to content

Switch druid_cube materialization SQL generation to v3 build path + support FULL strategy#2102

Draft
shangyian wants to merge 6 commits intoDataJunction:mainfrom
shangyian:mat-v2-full
Draft

Switch druid_cube materialization SQL generation to v3 build path + support FULL strategy#2102
shangyian wants to merge 6 commits intoDataJunction:mainfrom
shangyian:mat-v2-full

Conversation

@shangyian
Copy link
Copy Markdown
Collaborator

Summary

This PR replaces the v2 get_measures_query call in build_cube_materialization with the v3 build_measures_sql builder, bringing cube materialization SQL generation in line with the rest of the v3 query path. It adds two adapters: _v3_grain_group_to_measures_query and _v3_col_to_model_column that bridge v3's GrainGroupSQL output into the existing MeasuresMaterialization shape, so that downstream combiner/Druid config logic is unchanged.

It also fixes the FULL strategy: temporal partition filters are now only injected for INCREMENTAL_TIME; FULL materialization runs scan the full upstream as expected. Cube-level static filters still apply for both strategies.

Test Plan

  • PR has an associated issue: #
  • make check passes
  • make test shows 100% unit test coverage

Deployment Plan

@netlify
Copy link
Copy Markdown

netlify Bot commented May 8, 2026

Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
🔨 Latest commit 5f8c3d2
🔍 Latest deploy log https://app.netlify.com/projects/thriving-cassata-78ae72/deploys/69ff6bda05ca3d00080e85d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant