Draft
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
commented
Mar 20, 2026
| # Handle LIMITED aggregability (COUNT DISTINCT). | ||
| # If the grain group was pre-aggregated (is_pre_aggregated=True), the wrapper CTE | ||
| # already computed COUNT(DISTINCT grain_key) and stored it as a named column. | ||
| # Emit SUM(pre_agg_col) — a no-op re-aggregation since the wrapper produces |
Collaborator
Author
There was a problem hiding this comment.
We have to aggregate to the right grain before we combine these metrics to remove chances of double counting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan