[build v3] Fix dimension node join's upstream expansion#1905
Merged
shangyian merged 8 commits intoDataJunction:mainfrom Mar 19, 2026
Merged
[build v3] Fix dimension node join's upstream expansion#1905shangyian merged 8 commits intoDataJunction:mainfrom
shangyian merged 8 commits intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
…k_submit_query unless truly needed
shangyian
changed the title
shangyian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where we don't expand a joined-in dimension node's upstream references.
Test Plan
Changed the client tests so that they mostly don't rely on checking for actual matching SQL (the purpose of the client tests is to test client-specific functionality, not server functionality like SQL gen).
make checkpassesmake testshows 100% unit test coverageDeployment Plan