Listen on both TCP and named pipes when a pipe name is configured#94
Draft
Listen on both TCP and named pipes when a pipe name is configured#94
Conversation
When a named pipe name is configured, the mini agent now starts both a TCP listener and a named pipe listener concurrently. This ensures backwards compatibility — older tracers that only support TCP can still communicate with the compat binary, while new tracers use named pipes for multi-function isolation. When no pipe name is configured, behavior is unchanged (TCP only). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…_pipe serve_tcp now delegates to serve_accept_loop_tcp instead of duplicating the accept loop logic. serve_named_pipe is removed as it was replaced by serve_accept_loop_named_pipe in the prior commit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Lewis-E
force-pushed
the
lewis/SVLS-8243/named-pipe-backwards-compatability
branch
from
28db9c8 to
131147e
Compare
On Windows, the flusher handles are borrowed as &mut in the tokio::select! block when both TCP and named pipe transports are active. On other platforms this branch is dead code, so allow(unused_mut) suppresses the warning. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a named pipe name is configured, the mini agent now starts both a TCP listener and a named pipe listener concurrently. This ensures backwards compatibility — older tracers that only support TCP can still communicate with the compat binary, while new tracers use named pipes for multi-function isolation.
When no pipe name is configured, behavior is unchanged (TCP only).
What does this PR do?
Motivation
Additional Notes
Describe how to test/QA your changes