Skip to content

Implement sed builtin command #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexandreYang wants to merge 14 commits into
base: main
Choose a base branch
from
+4,263 −10
Open

Implement sed builtin command #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a6ffbb7
Implement sed builtin command with full script parser and safety hard…
AlexandreYang Mar 11, 2026
3500bd8
Split sed.go into types.go, parser.go, engine.go for readability
AlexandreYang Mar 11, 2026
335f784
Add 29 sed test scenarios covering P, D, T, groups, flags, escapes, n…
AlexandreYang Mar 11, 2026
47447f8
update .claude/skills/code-review/SKILL.md
AlexandreYang Mar 11, 2026
ed64b73
update .claude/skills/code-review/SKILL.md
AlexandreYang Mar 12, 2026
ad97529
Address review comments: fix 8 sed bugs for bash compatibility
AlexandreYang Mar 12, 2026
1d2a56c
Revert "update .claude/skills/code-review/SKILL.md"
AlexandreYang Mar 12, 2026
31f29b7
Revert "update .claude/skills/code-review/SKILL.md"
AlexandreYang Mar 12, 2026
9b95622
Address review comments: fix 7 more sed bugs for bash compatibility
AlexandreYang Mar 12, 2026
ff0dc37
Skip TestPentestDevNull on Windows where /dev/null is unavailable
AlexandreYang Mar 12, 2026
4ecccf7
Address review comments: fix q+append flush, reject s///0, add pentes…
AlexandreYang Mar 12, 2026
85c6110
Fix 3 review comments: l command octal escapes, \a\b\f\r in s///, tot…
AlexandreYang Mar 12, 2026
4f8452a
Address review comments: fix 6 sed bugs for bash compatibility
AlexandreYang Mar 12, 2026
a3d2b45
Address review comments: fix 6 more sed bugs for bash compatibility
AlexandreYang Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions SHELL_FEATURES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Blocked features are rejected before execution with exit code 2.
- ✅ `grep [-EFGivclLnHhoqsxw] [-e PATTERN] [-m NUM] [-A NUM] [-B NUM] [-C NUM] PATTERN [FILE]...` — print lines that match patterns; uses RE2 regex engine (linear-time, no backtracking)
- ✅ `head [-n N|-c N] [-q|-v] [-z] [FILE]...` — output the first part of files (default: first 10 lines)
- ✅ `ls [-1aAdFhlpRrSt] [FILE]...` — list directory contents
- ✅ `sed [-n] [-e SCRIPT] [-E|-r] [SCRIPT] [FILE]...` — stream editor for filtering and transforming text; uses RE2 regex engine; `-i`/`-f` rejected; `e`/`w`/`W`/`r`/`R` commands blocked
- ✅ `strings [-a] [-n MIN] [-t o|d|x] [-o] [-f] [-s SEP] [FILE]...` — print printable character sequences in files (default min length 4); offsets via `-t`/`-o`; filename prefix via `-f`; custom separator via `-s`
- ✅ `tail [-n N|-c N] [-q|-v] [-z] [FILE]...` — output the last part of files (default: last 10 lines); supports `+N` offset mode; `-f`/`--follow` is rejected
- ✅ `true` — return exit code 0
Expand Down
Loading
Loading