Skip to content

Switch time profiling to use lazy load stop and collect method by default#305

Draft
IlyasShabi wants to merge 1 commit intomainfrom
ishabi/use-stop-and-collect
Draft

Switch time profiling to use lazy load stop and collect method by default#305
IlyasShabi wants to merge 1 commit intomainfrom
ishabi/use-stop-and-collect

Conversation

@IlyasShabi
Copy link

What does this PR do?:
Switch time profiling to use stopAndCollect instead of the legacy stop, and remove the old code path.

Motivation:
PR #287 showed (via CI benchmarks) that stopAndCollect cuts memory usage by ~52% for a significant profile size. This change makes using stop and collect as the default for time profiling.

@IlyasShabi IlyasShabi added the semver-patch Bug or security fixes, mainly label Mar 19, 2026
@github-actions
Copy link

Overall package size

Self size: 2.01 MB
Deduped: 2.37 MB
No deduping: 2.37 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Mar 19, 2026

Benchmarks

Benchmark execution time: 2026-03-19 15:41:46

Comparing candidate commit b085254 in PR branch ishabi/use-stop-and-collect with baseline commit 2d2b6ea in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 92 metrics, 28 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch Bug or security fixes, mainly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant