[AGTMETRICS-209]Supress external env if origin detection is configured off. #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remeh
approved these changes
Aug 6, 2025
| if ((isset($config["origin_detection"]) && !$config["origin_detection"])) { | ||
| return false; | ||
| if (isset($config["origin_detection"])) { | ||
| return $config["origin_detection"]; |
There was a problem hiding this comment.
I'm a bit rusty on PHP, but would that be worth doing a boolean test?
return $config["origin_detection"] == true;
or is this array access enough for what we want?
Contributor
Author
There was a problem hiding this comment.
This is testing if the value is truthy, rather than strict true, so you could configure 'origin_detection' => 42 and it would be true. From my understanding it is more idiomatic PHP to accept truthy values rather than expect a strict true to be passed in this situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Origin Detection is configured to be off, we should not output the external env value.