Skip to content

test(crashtracking): add minimal LD preload test for crashtracker collector #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gyuheon0h wants to merge 18 commits into
base: main
Choose a base branch
from
Open

test(crashtracking): add minimal LD preload test for crashtracker collector #1428

gyuheon0h wants to merge 18 commits into from
+334 −6

Conversation

@gyuheon0h
Copy link
Contributor

@gyuheon0h gyuheon0h commented Jan 4, 2026 •
edited
Loading

What does this PR do?

  1. Adds test_collector_no_allocations_stacktrace_modes, which runs the crash tracker under LD_PRELOAD with a custom allocator hook that logs any allocation in the collector.
  2. Executes the crashtracker binary across all StacktraceCollection modes via the env var DD_TEST_STACKTRACE_COLLECTION:
    • disabled
    • without_symbols
    • receiver_symbols
    • inprocess_symbols
  3. For each mode, the test:
    • Cleans any previous /tmp/preload_detector.log
    • Runs the crashtracker null-deref scenario with TestMode::RuntimePreloadLogger
    • After the run, checks for /tmp/preload_detector.log
    • If the mode is inprocess_symbols, it expects the log to exist (symbol resolution is known to allocate); logs are printed if present.
    • For the other modes, it expects no log.

Motivation

We want to validate all uses of non-signal-safe functions in the handler.

How to test the change?

You can run the test_collector_no_allocations_stacktrace_modes test. You can also add allocations in the signal hander path and observe the test behavior

@gyuheon0h Graphite App
Copy link
Contributor Author

gyuheon0h commented Jan 4, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gyuheon0h gyuheon0h changed the title First pass, need to isolate only collector from test harness [crashtracking] Add minimal LD preload test for crashtracker collector Jan 4, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 34.42623% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.25%. Comparing base (65a5d9a) to head (6fed733).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1428      +/-   ##
==========================================
- Coverage   71.32%   71.25%   -0.08%     
==========================================
  Files         416      416              
  Lines       66781    66850      +69     
==========================================
+ Hits        47631    47633       +2     
- Misses      19150    19217      +67
Components Coverage Δ
libdd-crashtracker 61.10% <0.00%> (-0.02%) ⬇️
libdd-crashtracker-ffi 15.08% <ø> (+0.71%) ⬆️
libdd-alloc 98.73% <ø> (ø)
libdd-data-pipeline 85.75% <ø> (-0.29%) ⬇️
libdd-data-pipeline-ffi 77.01% <ø> (ø)
libdd-common 80.84% <ø> (-0.27%) ⬇️
libdd-common-ffi 74.19% <ø> (ø)
libdd-telemetry 60.26% <ø> (+0.03%) ⬆️
libdd-telemetry-ffi 21.17% <ø> (ø)
libdd-dogstatsd-client 83.75% <ø> (ø)
datadog-ipc 82.61% <ø> (ø)
libdd-profiling 80.65% <ø> (-0.42%) ⬇️
libdd-profiling-ffi 62.46% <ø> (+0.03%) ⬆️
datadog-sidecar 36.37% <ø> (+0.37%) ⬆️
datdog-sidecar-ffi 13.37% <ø> (+1.91%) ⬆️
spawn-worker 55.18% <ø> (ø)
libdd-tinybytes 92.44% <ø> (ø)
libdd-trace-normalization 82.33% <ø> (ø)
libdd-trace-obfuscation 94.17% <ø> (ø)
libdd-trace-protobuf 61.18% <ø> (ø)
libdd-trace-utils 89.89% <ø> (+0.14%) ⬆️
datadog-tracer-flare 59.74% <ø> (-1.33%) ⬇️
libdd-log 75.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Jan 4, 2026 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2026-01-15 21:29:38

Comparing candidate commit 6fed733 in PR branch gyuheon0h/prof-13289-ld-preload_ with baseline commit 3f47244 in branch main.

Found 6 performance improvements and 5 performance regressions! Performance is the same for 46 metrics, 2 unstable metrics.

scenario:benching serializing traces from their internal representation to msgpack

  • 🟥 execution_time [+927.886µs; +939.961µs] or [+6.681%; +6.768%]

scenario:credit_card/is_card_number/ 3782-8224-6310-005

  • 🟥 execution_time [+3.584µs; +3.882µs] or [+4.582%; +4.963%]
  • 🟥 throughput [-607316.631op/s; -559857.012op/s] or [-4.749%; -4.378%]

scenario:credit_card/is_card_number/378282246310005

  • 🟥 execution_time [+3.383µs; +3.584µs] or [+4.935%; +5.229%]
  • 🟥 throughput [-728142.455op/s; -685658.952op/s] or [-4.991%; -4.700%]

scenario:credit_card/is_card_number/x371413321323331

  • 🟩 execution_time [-532.726ns; -518.810ns] or [-8.275%; -8.059%]
  • 🟩 throughput [+13627693.677op/s; +14025450.310op/s] or [+8.773%; +9.029%]

scenario:credit_card/is_card_number_no_luhn/x371413321323331

  • 🟩 execution_time [-544.461ns; -531.185ns] or [-8.460%; -8.254%]
  • 🟩 throughput [+13989715.669op/s; +14371421.094op/s] or [+9.003%; +9.249%]

scenario:normalization/normalize_name/normalize_name/good

  • 🟩 execution_time [-555.464ns; -530.550ns] or [-5.301%; -5.064%]
  • 🟩 throughput [+5099514.603op/s; +5345513.423op/s] or [+5.343%; +5.601%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 89.822µs 90.146µs ± 0.179µs 90.128µs ± 0.059µs 90.187µs 90.270µs 90.520µs 92.075µs 2.16% 7.362 71.332 0.20% 0.013µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [90.122µs; 90.171µs] or [-0.028%; +0.028%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 495.161µs 496.055µs ± 0.758µs 495.932µs ± 0.264µs 496.273µs 496.768µs 497.028µs 505.204µs 1.87% 8.867 104.298 0.15% 0.054µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1979397.551op/s 2015911.611op/s ± 3040.304op/s 2016405.249op/s ± 1072.598op/s 2017274.425op/s 2018357.420op/s 2019075.397op/s 2019544.931op/s 0.16% -8.741 102.262 0.15% 214.982op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 370.997µs 371.871µs ± 0.305µs 371.859µs ± 0.208µs 372.082µs 372.385µs 372.610µs 372.691µs 0.22% 0.021 -0.113 0.08% 0.022µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2683184.506op/s 2689104.863op/s ± 2203.278op/s 2689192.748op/s ± 1507.028op/s 2690678.516op/s 2692768.286op/s 2693739.453op/s 2695439.902op/s 0.23% -0.017 -0.112 0.08% 155.795op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 169.523µs 169.952µs ± 0.213µs 169.945µs ± 0.086µs 170.027µs 170.187µs 170.388µs 171.533µs 0.93% 3.742 25.788 0.13% 0.015µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5829783.643op/s 5884020.035op/s ± 7355.507op/s 5884253.786op/s ± 2962.293op/s 5887330.374op/s 5893461.001op/s 5896388.800op/s 5898893.803op/s 0.25% -3.690 25.328 0.12% 520.113op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.271µs 37.428µs ± 0.059µs 37.424µs ± 0.041µs 37.466µs 37.526µs 37.581µs 37.582µs 0.42% 0.209 -0.030 0.16% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26608410.277op/s 26718174.054op/s ± 42165.019op/s 26720842.374op/s ± 29417.798op/s 26749963.259op/s 26780812.312op/s 26811447.666op/s 26830563.697op/s 0.41% -0.200 -0.033 0.16% 2981.517op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 46.190µs 46.301µs ± 0.114µs 46.293µs ± 0.037µs 46.330µs 46.382µs 46.427µs 47.713µs 3.07% 9.642 117.445 0.24% 0.008µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20958788.353op/s 21597966.459op/s ± 51796.012op/s 21601617.568op/s ± 17060.922op/s 21617927.453op/s 21638996.092op/s 21647884.496op/s 21649824.907op/s 0.22% -9.448 114.254 0.24% 3662.531op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [495.950µs; 496.160µs] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [2015490.254op/s; 2016332.968op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [371.829µs; 371.913µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2688799.509op/s; 2689410.216op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [169.923µs; 169.982µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5883000.633op/s; 5885039.438op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.420µs; 37.436µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26712330.388op/s; 26724017.720op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.285µs; 46.317µs] or [-0.034%; +0.034%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21590788.030op/s; 21605144.888op/s] or [-0.033%; +0.033%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.753ms 14.822ms ± 0.031ms 14.821ms ± 0.017ms 14.836ms 14.866ms 14.933ms 14.953ms 0.89% 1.288 3.758 0.21% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.817ms; 14.826ms] or [-0.029%; +0.029%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 3.949ms 3.959ms ± 0.008ms 3.957ms ± 0.003ms 3.960ms 3.966ms 3.984ms 4.047ms 2.26% 6.466 60.424 0.21% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [3.958ms; 3.960ms] or [-0.029%; +0.029%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 34.008µs 34.523µs ± 0.739µs 34.242µs ± 0.134µs 34.319µs 36.062µs 36.112µs 37.776µs 10.32% 1.799 1.967 2.14% 0.052µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.420µs; 34.625µs] or [-0.297%; +0.297%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.743µs 26.180µs ± 9.741µs 18.140µs ± 0.202µs 34.295µs 44.474µs 44.769µs 64.257µs 254.22% 0.775 -0.273 37.12% 0.689µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.830µs; 27.530µs] or [-5.157%; +5.157%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 161.429µs 162.064µs ± 0.371µs 161.988µs ± 0.108µs 162.162µs 162.515µs 162.934µs 166.032µs 2.50% 6.559 64.529 0.23% 0.026µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [162.012µs; 162.115µs] or [-0.032%; +0.032%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.181µs 3.248µs ± 1.429µs 3.007µs ± 0.038µs 3.062µs 3.720µs 14.114µs 14.728µs 389.81% 7.222 53.832 43.89% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.050µs; 3.446µs] or [-6.097%; +6.097%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.332µs 2.400µs ± 0.019µs 2.405µs ± 0.007µs 2.411µs 2.430µs 2.439µs 2.450µs 1.83% -1.187 2.652 0.80% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.398µs; 2.403µs] or [-0.111%; +0.111%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 186.274µs 186.828µs ± 0.433µs 186.703µs ± 0.159µs 186.906µs 187.942µs 188.200µs 188.658µs 1.05% 1.967 3.641 0.23% 0.031µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5300606.681op/s 5352541.943op/s ± 12342.890op/s 5356107.861op/s ± 4562.809op/s 5359964.316op/s 5364106.174op/s 5367063.755op/s 5368445.112op/s 0.23% -1.955 3.590 0.23% 872.774op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.534µs 17.634µs ± 0.042µs 17.630µs ± 0.027µs 17.660µs 17.705µs 17.737µs 17.827µs 1.12% 0.612 1.437 0.24% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 56094983.670op/s 56708075.870op/s ± 136124.960op/s 56721249.963op/s ± 86972.761op/s 56801410.627op/s 56914173.375op/s 56970235.171op/s 57033164.054op/s 0.55% -0.590 1.367 0.24% 9625.488op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 9.851µs 9.935µs ± 0.084µs 9.918µs ± 0.026µs 9.938µs 10.141µs 10.166µs 10.222µs 3.06% 1.745 2.070 0.84% 0.006µs 1 200
normalization/normalize_name/normalize_name/good throughput 97832041.950op/s 100662659.252op/s ± 837101.603op/s 100829790.394op/s ± 266256.886op/s 101169441.867op/s 101427225.455op/s 101484097.984op/s 101514518.528op/s 0.68% -1.719 1.996 0.83% 59192.022op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [186.768µs; 186.888µs] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5350831.337op/s; 5354252.549op/s] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [17.628µs; 17.640µs] or [-0.033%; +0.033%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [56689210.259op/s; 56726941.480op/s] or [-0.033%; +0.033%] None None None
normalization/normalize_name/normalize_name/good execution_time [9.923µs; 9.946µs] or [-0.117%; +0.117%] None None None
normalization/normalize_name/normalize_name/good throughput [100546645.021op/s; 100778673.483op/s] or [-0.115%; +0.115%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 545.533µs 546.216µs ± 0.331µs 546.188µs ± 0.193µs 546.392µs 546.720µs 546.927µs 548.599µs 0.44% 1.951 12.049 0.06% 0.023µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [546.170µs; 546.262µs] or [-0.008%; +0.008%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.945µs 5.009µs ± 0.045µs 4.992µs ± 0.036µs 5.033µs 5.080µs 5.087µs 5.099µs 2.15% 0.374 -1.226 0.90% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.003µs; 5.015µs] or [-0.125%; +0.125%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 186.460ns 190.437ns ± 2.156ns 190.241ns ± 1.615ns 191.623ns 194.970ns 197.595ns 198.241ns 4.21% 1.114 1.319 1.13% 0.152ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [190.138ns; 190.736ns] or [-0.157%; +0.157%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 61.008ms 61.475ms ± 2.513ms 61.167ms ± 0.043ms 61.207ms 61.293ms 80.534ms 83.578ms 36.64% 8.022 62.715 4.08% 0.178ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [61.127ms; 61.823ms] or [-0.567%; +0.567%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 145.059µs 146.819µs ± 1.593µs 146.512µs ± 0.569µs 147.125µs 148.548µs 152.252µs 161.605µs 10.30% 5.241 40.152 1.08% 0.113µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [146.598µs; 147.040µs] or [-0.150%; +0.150%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.893µs 3.911µs ± 0.003µs 3.911µs ± 0.001µs 3.913µs 3.916µs 3.920µs 3.926µs 0.39% 0.191 8.843 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 254700534.204op/s 255676215.352op/s ± 199039.099op/s 255701273.832op/s ± 95093.861op/s 255794852.129op/s 255879707.818op/s 255978465.639op/s 256871359.064op/s 0.46% -0.166 8.908 0.08% 14074.190op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 80.459µs 81.943µs ± 0.566µs 81.970µs ± 0.349µs 82.321µs 82.889µs 83.181µs 83.381µs 1.72% -0.055 -0.201 0.69% 0.040µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11993146.884op/s 12204215.233op/s ± 84319.073op/s 12199643.427op/s ± 52218.695op/s 12251838.820op/s 12354177.679op/s 12397401.645op/s 12428700.355op/s 1.88% 0.092 -0.194 0.69% 5962.259op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 74.317µs 74.897µs ± 0.139µs 74.882µs ± 0.068µs 74.967µs 75.102µs 75.250µs 75.612µs 0.97% 0.199 5.163 0.19% 0.010µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13225468.779op/s 13351716.567op/s ± 24789.382op/s 13354348.162op/s ± 12122.661op/s 13364411.911op/s 13380598.467op/s 13428136.945op/s 13455855.255op/s 0.76% -0.160 5.121 0.19% 1752.874op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.891µs 3.911µs ± 0.002µs 3.911µs ± 0.001µs 3.913µs 3.914µs 3.916µs 3.918µs 0.17% -2.595 22.107 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255247650.114op/s 255684982.610op/s ± 158246.862op/s 255683508.414op/s ± 90499.647op/s 255770682.228op/s 255887061.127op/s 255918487.860op/s 257000189.660op/s 0.51% 2.627 22.425 0.06% 11189.743op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 71.307µs 72.038µs ± 0.163µs 72.046µs ± 0.082µs 72.128µs 72.265µs 72.404µs 72.423µs 0.52% -0.888 2.906 0.23% 0.012µs 1 200
credit_card/is_card_number/378282246310005 throughput 13807688.697op/s 13881690.991op/s ± 31498.944op/s 13879953.184op/s ± 15709.069op/s 13894778.696op/s 13935318.740op/s 13983530.001op/s 14023845.986op/s 1.04% 0.916 2.991 0.23% 2227.312op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.131µs 52.193µs ± 0.034µs 52.187µs ± 0.020µs 52.210µs 52.252µs 52.303µs 52.341µs 0.30% 1.064 2.017 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19105435.735op/s 19159745.193op/s ± 12474.839op/s 19161908.999op/s ± 7290.972op/s 19168497.533op/s 19176016.653op/s 19180415.128op/s 19182584.132op/s 0.11% -1.059 1.996 0.06% 882.104op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 5.756µs 5.912µs ± 0.050µs 5.911µs ± 0.033µs 5.937µs 5.998µs 6.032µs 6.033µs 2.06% -0.011 -0.041 0.84% 0.004µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165748332.636op/s 169162640.428op/s ± 1430088.675op/s 169167992.336op/s ± 942224.081op/s 170192109.509op/s 171471598.707op/s 172548749.289op/s 173726775.480op/s 2.69% 0.061 -0.018 0.84% 101122.540op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.892µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.916µs 3.919µs 3.921µs 0.26% -0.603 7.938 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255064303.237op/s 255689383.100op/s ± 192263.387op/s 255719498.637op/s ± 113510.254op/s 255811207.552op/s 255915539.745op/s 255952896.307op/s 256923753.530op/s 0.47% 0.625 8.064 0.08% 13595.074op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.045µs 64.236µs ± 0.086µs 64.221µs ± 0.040µs 64.264µs 64.380µs 64.496µs 64.629µs 0.64% 1.458 3.671 0.13% 0.006µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15472910.158op/s 15567660.326op/s ± 20800.757op/s 15571190.961op/s ± 9602.079op/s 15580118.989op/s 15594674.497op/s 15599342.504op/s 15613994.824op/s 0.27% -1.444 3.609 0.13% 1470.836op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.337µs 57.504µs ± 0.096µs 57.484µs ± 0.043µs 57.543µs 57.656µs 57.894µs 58.181µs 1.21% 2.688 13.643 0.17% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17187833.385op/s 17390289.319op/s ± 28876.994op/s 17396275.457op/s ± 13008.455op/s 17407075.976op/s 17425378.757op/s 17429021.946op/s 17440835.973op/s 0.26% -2.647 13.284 0.17% 2041.912op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.893µs 3.911µs ± 0.003µs 3.911µs ± 0.001µs 3.912µs 3.915µs 3.919µs 3.923µs 0.31% -0.792 12.555 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254903272.884op/s 255669348.460op/s ± 174242.587op/s 255681843.763op/s ± 81678.646op/s 255753375.387op/s 255871811.365op/s 255934450.545op/s 256884086.483op/s 0.47% 0.820 12.710 0.07% 12320.812op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.567µs 54.779µs ± 0.160µs 54.732µs ± 0.076µs 54.833µs 55.106µs 55.242µs 55.504µs 1.41% 1.515 2.517 0.29% 0.011µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 18016687.588op/s 18255439.399op/s ± 53202.545op/s 18270689.250op/s ± 25434.762op/s 18291004.941op/s 18315288.871op/s 18323732.422op/s 18325960.556op/s 0.30% -1.495 2.429 0.29% 3761.988op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.143µs 52.198µs ± 0.042µs 52.189µs ± 0.016µs 52.209µs 52.249µs 52.306µs 52.547µs 0.69% 4.311 29.311 0.08% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19030416.156op/s 19157978.981op/s ± 15343.254op/s 19161142.162op/s ± 5972.819op/s 19166366.860op/s 19172090.996op/s 19176602.857op/s 19178127.346op/s 0.09% -4.281 28.977 0.08% 1084.932op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 5.755µs 5.898µs ± 0.048µs 5.896µs ± 0.032µs 5.928µs 5.974µs 5.998µs 6.025µs 2.19% -0.078 0.081 0.81% 0.003µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 165986969.040op/s 169565226.925op/s ± 1374398.984op/s 169618937.279op/s ± 933020.069op/s 170555606.255op/s 171712239.156op/s 172916111.681op/s 173762607.954op/s 2.44% 0.129 0.109 0.81% 97184.684op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [255648630.447op/s; 255703800.256op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [81.864µs; 82.021µs] or [-0.096%; +0.096%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12192529.421op/s; 12215901.046op/s] or [-0.096%; +0.096%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [74.878µs; 74.916µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13348280.997op/s; 13355152.137op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.911µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631 throughput [255663051.117op/s; 255706914.103op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/378282246310005 execution_time [72.015µs; 72.060µs] or [-0.031%; +0.031%] None None None
credit_card/is_card_number/378282246310005 throughput [13877325.541op/s; 13886056.442op/s] or [-0.031%; +0.031%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.188µs; 52.197µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19158016.300op/s; 19161474.086op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [5.905µs; 5.919µs] or [-0.117%; +0.117%] None None None
credit_card/is_card_number/x371413321323331 throughput [168964443.891op/s; 169360836.964op/s] or [-0.117%; +0.117%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.911µs; 3.911µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255662737.243op/s; 255716028.956op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.224µs; 64.248µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15564777.542op/s; 15570543.111op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.490µs; 57.517µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17386287.245op/s; 17394291.393op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.911µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255645200.113op/s; 255693496.807op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.756µs; 54.801µs] or [-0.041%; +0.041%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18248066.038op/s; 18262812.760op/s] or [-0.040%; +0.040%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.192µs; 52.203µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19155852.554op/s; 19160105.408op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [5.891µs; 5.904µs] or [-0.112%; +0.112%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [169374748.444op/s; 169755705.405op/s] or [-0.112%; +0.112%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 243.274ns 252.606ns ± 12.150ns 247.443ns ± 2.784ns 255.306ns 277.448ns 294.174ns 298.176ns 20.50% 2.017 3.490 4.80% 0.859ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [250.922ns; 254.290ns] or [-0.667%; +0.667%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 9.689ms 10.003ms ± 0.079ms 10.015ms ± 0.029ms 10.043ms 10.097ms 10.156ms 10.193ms 1.78% -1.495 3.698 0.79% 0.006ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [9.992ms; 10.014ms] or [-0.109%; +0.109%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6fed733 1768511599 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.533ms 10.561ms ± 0.014ms 10.560ms ± 0.010ms 10.570ms 10.581ms 10.607ms 10.625ms 0.62% 0.829 2.302 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.559ms; 10.563ms] or [-0.019%; +0.019%] None None None

Baseline

Omitted due to size.

@dd-octo-sts
Copy link

dd-octo-sts bot commented Jan 4, 2026 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 87.83 MB 87.83 MB +0% (+280 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.57 MB 7.57 MB 0% (0 B) 👌
aarch64-apple-darwin
Artifact Baseline Commit Change
/aarch64-apple-darwin/lib/libdatadog_profiling.a 59.48 MB 59.48 MB +0% (+8 B) 👌
/aarch64-apple-darwin/lib/libdatadog_profiling.dylib 8.58 MB 8.58 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 101.57 MB 101.57 MB +0% (+504 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.71 MB 9.71 MB +0% (+24 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 20.44 MB 20.44 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 73.49 KB 73.49 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 151.28 MB 151.27 MB -0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 817.84 MB 817.84 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 6.51 MB 6.51 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 73.49 KB 73.49 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 20.14 MB 20.14 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 39.52 MB 39.52 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 17.43 MB 17.43 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 74.62 KB 74.62 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 154.16 MB 154.15 MB -0% (-8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 805.63 MB 805.63 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 5.01 MB 5.01 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 74.62 KB 74.62 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 21.47 MB 21.47 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 37.29 MB 37.29 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 76.08 MB 76.08 MB +0% (+568 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.00 MB 9.00 MB 0% (0 B) 👌
x86_64-apple-darwin
Artifact Baseline Commit Change
/x86_64-apple-darwin/lib/libdatadog_profiling.a 60.79 MB 60.79 MB +0% (+16 B) 👌
/x86_64-apple-darwin/lib/libdatadog_profiling.dylib 9.63 MB 9.63 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 95.67 MB 95.67 MB +0% (+552 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.45 MB 10.45 MB 0% (0 B) 👌

@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-13289-ld-preload_ branch from c9a32e0 to 5d2087f Compare January 6, 2026 15:46
danielsn
danielsn reviewed Jan 6, 2026
View reviewed changes
bin_tests/preload/preload.c Outdated
}

void *ptr = real_malloc(size);
log_line("malloc", size, ptr);
Copy link
Contributor

@danielsn danielsn Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a global atomic that controls whether to log, enabled when the signal handler is active disabled otherwise?

Copy link
Contributor Author

@gyuheon0h gyuheon0h Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something similar with static __thread int dd_is_collector = 0; on line 26. This gets called on collector init

@gyuheon0h gyuheon0h changed the title [crashtracking] Add minimal LD preload test for crashtracker collector [WIP][crashtracking] Add minimal LD preload test for crashtracker collector Jan 6, 2026
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-13289-ld-preload_ branch from e2ed49c to 677bb4f Compare January 12, 2026 02:34
@gyuheon0h gyuheon0h changed the title [WIP][crashtracking] Add minimal LD preload test for crashtracker collector [crashtracking] Add minimal LD preload test for crashtracker collector Jan 12, 2026
@gyuheon0h gyuheon0h changed the title [crashtracking] Add minimal LD preload test for crashtracker collector tests(crashtrackinh): add minimal LD preload test for crashtracker collector Jan 12, 2026
@gyuheon0h gyuheon0h changed the title tests(crashtrackinh): add minimal LD preload test for crashtracker collector tests(crashtracking): add minimal LD preload test for crashtracker collector Jan 12, 2026
@gyuheon0h gyuheon0h changed the title tests(crashtracking): add minimal LD preload test for crashtracker collector test(crashtracking): add minimal LD preload test for crashtracker collector Jan 12, 2026
@gyuheon0h gyuheon0h changed the title test(crashtracking): add minimal LD preload test for crashtracker collector [WIP] test(crashtracking): add minimal LD preload test for crashtracker collector Jan 12, 2026
@gyuheon0h gyuheon0h changed the title [WIP] test(crashtracking): add minimal LD preload test for crashtracker collector test(crashtracking): add minimal LD preload test for crashtracker collector Jan 12, 2026
@gyuheon0h gyuheon0h marked this pull request as ready for review January 12, 2026 21:26
@gyuheon0h gyuheon0h requested review from a team as code owners January 12, 2026 21:26
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-13289-ld-preload_ branch 3 times, most recently from c8ebe5f to 93c78fb Compare January 14, 2026 19:46
@DataDog DataDog deleted a comment from datadog-datadog-prod-us1 bot Jan 14, 2026
@DataDog DataDog deleted a comment from chatgpt-codex-connector bot Jan 14, 2026
@DataDog DataDog deleted a comment from chatgpt-codex-connector bot Jan 14, 2026
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-13289-ld-preload_ branch 2 times, most recently from 9437e20 to ff6feed Compare January 14, 2026 20:00
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-13289-ld-preload_ branch from ff6feed to 5cf9c7d Compare January 14, 2026 20:13
gleocadie
gleocadie reviewed Jan 15, 2026
View reviewed changes
Copy link
Contributor

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start :)
Few requests/questions.
One thing we should improve is to have it for multiple situations in the collector.
At first we can focus on that it's working in in process symbols resolution (if there is a test for that, we should expect that the test will fail)
and the rest should be mark as expect to success.

Did you check that it's actually working ?

@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-13289-ld-preload_ branch 3 times, most recently from 40e549b to 301c04f Compare January 15, 2026 20:59
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-13289-ld-preload_ branch from 301c04f to 6fed733 Compare January 15, 2026 21:13
@gyuheon0h gyuheon0h requested a review from gleocadie January 15, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielsn danielsn Awaiting requested review from danielsn

@gleocadie gleocadie Awaiting requested review from gleocadie

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

crashtracker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gyuheon0h @codecov-commenter @danielsn @gleocadie